search

elifesciences / api-sdk-php

PHP SDK for the eLife Sciences API
MIT License
0 stars 3 forks source link

Bump version of collection and highlights list to support digests #190

Closed nlisgo closed 6 years ago

nlisgo commented 6 years ago

Improves: elifesciences/issues#4294

thewilkybarkid commented 6 years ago

Looks like a PHP-CS-Fixer update has started to find some new problems on existing code. We should have a separate PR to fix that first.

nlisgo commented 6 years ago

Looks like a PHP-CS-Fixer update has started to find some new problems on existing code. We should have a separate PR to fix that first.

https://github.com/elifesciences/api-sdk-php/pull/191

nlisgo commented 6 years ago

There are a few instances of duplication of api versions. I have discussed this with @giorgiosironi and we agree that it would be great to take this on as part of the issue: elifesciences/issues#4294.

I have added a todo item.

thewilkybarkid commented 6 years ago

Looks good. We'll have to wait for the new versions to be available before merging.