Code cleanup and linting

elifesciences / elife-crossref-feed

code to support uploading info to crossref on PAW articles

1 stars 1 forks source link

Code cleanup and linting #139

Closed gnott closed 5 years ago

gnott commented 5 years ago

Noticed when updating elife-crossref-xml-generation library, it can use some updates for coding style, especially in the use of self variable usage. Use the proofreader to clean things up!

[x] Clean up / refactor excessive self. class variable usage
[x] Refactor any functions that have no-self-use
[x] Linting for code style
[x] Move functions into separate modules to reduce the size of the generate.py module

gnott commented 5 years ago

I'm going to work on this issue before issue https://github.com/elifesciences/elife-crossref-feed/issues/123.

gnott commented 5 years ago

Code in review, will wait for some feedback.

gnott commented 5 years ago

PR is merged that included the clean-up and refactoring I intended as the crux of this issue, so closing it as completed!