elifesciences / elife-crossref-feed

code to support uploading info to crossref on PAW articles
1 stars 1 forks source link

Crossref to support acceptance_date in version 4.4.2 of schema #143

Closed Melissa37 closed 3 years ago

Melissa37 commented 5 years ago

Problem / Motivation

Proposed solution

Clarification needed and assumptions


Tasks

Technical notes

@gnott

User interface / Wireframes

NA

gnott commented 5 years ago

Does this <date> tag always appear inside the <history> tag?

For eLife articles, we have this date present in the Article object.

Looking at the Crossref XML schema, I think we would probably put this date something like this format:

<acceptance_date media_type="online">
<month>08</month>
<day>22</day>
<year>2019</year>
</acceptance_date>

The media_type="online" if not specified I think defaults to media_type="print" when Crossref processes the deposit. Currently our Crossref generation code sets all <publication_date media_type="online"> tags to "online". If we want to support different media_type values (for other journals) that may need some expansion.

gnott commented 5 years ago

Also noting <acceptance_date> is available in the 4.4.1 version of the schema - https://www.crossref.org/schemas/common4.4.1.xsd

Melissa37 commented 5 years ago

Ah, that's interesting. Any ideas of how easy it would be to add it? :-)

M

Melissa Harrison Head of Production Operations

Tel: +44 1223 855340

http://elifesciences.org

On Thu, Aug 22, 2019 at 6:40 PM Graham Nott notifications@github.com wrote:

Also noting is available in the 4.4.1 version of the schema - https://www.crossref.org/schemas/common4.4.1.xsd

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elifesciences/elife-crossref-feed/issues/143?email_source=notifications&email_token=ABOFQJDFNNYMVMJJTVGSUKTQF3FPFA5CNFSM4IOWOSSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4527JQ#issuecomment-524005286, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOFQJGIY27A36R6TZNDB23QF3FPFANCNFSM4IOWOSSA .

-- eLife Sciences Publications, Ltd is a limited liability non-profit non-stock corporation incorporated in the State of Delaware, USA, with company number 5030732, and is registered in the UK with company number FC030576 and branch number BR015634 at the address Westbrook Centre, Milton Road, Cambridge, CB4 1YG.

gnott commented 5 years ago

Adding the date looks straightforward, if we stick to assuming it is type "online".

Melissa37 commented 5 years ago

Cool. However, I am a bit unsure of the need to add the online attribute because the acceptance date is not an online or print date, as nothing to do with publishing the article is actually associated with this date (if that makes sense?)?

It is in history but we should be mindful of <history> and <pub-history>. This is a definite <history> date as it's not recording a publication event.

fred-atherden commented 3 years ago

@gnott, given we're providing crossref with the acceptance_date for Pre-registered deposits (https://github.com/elifesciences/issues/issues/6569), do you think it might be worth revisiting this?

It looks like media_type is optional in 4.4.2, but we could provide electronic. What do you think?

fred-atherden commented 3 years ago

As discussed in our call today, @gnott to take a look and see if we're already providing Crossref with acceptance dates for article deposits (as we do with pre-registered dois).

If we are not, this is something which we could potentially add in prior to upgrading to schema version 5.3.1.

gnott commented 3 years ago

I checked, and it looks like this in particular has not been added yet. The first type of deposit to included an acceptance_date was in the pending_publication deposits.

When parsing the article XML, the accepted is included for some time now for eLife articles.

I'll add this next as an enhancement.

gnott commented 3 years ago

I see now the @media_type value is currently hard-coded on the <publication_date> tag, but for pending publication deposits the <acceptance_date> tag has no @media_type. I'm not sure what is best there, and I'm leaning towards not to bother with a @media_type for the acceptance date, especially in eLife's case where all articles are "online" anyway.

fred-atherden commented 3 years ago

Sounds good to me - let's leave @media_type out.

gnott commented 3 years ago

Thanks for confirming Fred, I went that route, and this feature was added a deployed yesterday. If there are no errors at Crossref today, I think we can consider this finished, and I'll close the issue now.