search

elifesciences / elife-crossref-xml-generation

Crossref deposit of journal articles
MIT License
4 stars 3 forks source link

eLife elocation_id and config refactoring #67

Closed gnott closed 6 years ago

gnott commented 6 years ago

Fixes https://github.com/elifesciences/elife-crossref-feed/issues/134.

Breaking change to how the configuration is specified and passed in the generation functions.

I started out aiming to solve the basic issue of including the elocation-id value for eLife deposits, which would have been possible by changing one configuration value.

Following to where in the elife-bot project this library is used, I noticed it was difficult to load the configuration file from a different location, since it was always preferring to load the default crossref.cfg file. Now, instead of specifying the config section to load, the config object itself is passed in to the generate functions, to allow for more flexibility.

The files in the test_data folder here should all be for eLife articles, and now include the elocation-id value.

Once this PR is ok and merged, I can continue with the elife-bot project integration based on the refactoring here.

I will also have a PR for the elife-bot-formula repo to deploy an updated crossref.cfg file to our production system.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.004%) to 99.74% when pulling 86b89f9ef132203f5310b67ae7f95a4226f18162 on feature-elife-elocation-id into e26049867fedd6954f0de2a02c86c66035629329 on develop.