Add given_name only if non-empty.

elifesciences / elife-crossref-xml-generation

Crossref deposit of journal articles

MIT License

4 stars 3 forks source link

Add given_name only if non-empty. #80

Closed gnott closed 5 years ago

gnott commented 5 years ago

Fixes https://github.com/elifesciences/elife-crossref-xml-generation/issues/79

Simple fix, with no expected backwards-compatibiltiy issues. Without this change there is the potential to create invalid Crossref deposit XML. Here we do not add an empty <given_name/> tag when a contributor has no given name specified.

gnott commented 5 years ago

Re: https://github.com/elifesciences/issues/issues/5193 is where this error observations is mentioned.

coveralls commented 5 years ago

Coverage increased (+0.003%) to 99.857% when pulling 99a8c3047782d753066e23e867d793b8fd198357 on given-name into f9458bf3b181f730c1f255051da4a5117f6a4093 on develop.