search

elifesciences / elife-poa-xml-generation

tools for creating XML for submission into elife's publish on accept workflow
MIT License
1 stars 3 forks source link

Merge develop branch to master #318

Closed gnott closed 6 years ago

gnott commented 6 years ago

To deploy the PDF decapitation timeout. Also, it seems we are not running the dockerised PDF decapitator in production yet, and if someone can please confirm we're ready to use it in production. I didn't realise it wasn't deployed yet.

lsh-0 commented 6 years ago

is this python2 or 3 code? because subprocess.popen has a timeout parameter in python3 that would obviate the need for the new dependency and all this code: https://docs.python.org/3.5/library/subprocess.html#subprocess.run

if python2 code, then it needs upgrading to python3 (pinging @seanwiseman )

also, if arrow is a dependency of a dependency (func_timeout) it probably shouldn't be in requirements.txt.

approving regardless.

gnott commented 6 years ago

Thanks Luke. It is run by the bot, so we still need Python 2 support in here I think.