search

elifesciences / elife-tools

Python library for parsing eLife article XML data.
MIT License
15 stars 7 forks source link

Refactor and remove duplicate_tag() #301

Closed gnott closed 5 years ago

gnott commented 5 years ago

Fixes https://github.com/elifesciences/elife-tools/issues/299 In reference to PR https://github.com/elifesciences/elife-tools/pull/298

I removed the uses of duplicate_tag() where used to see if the tests still pass. One place still required a duplicate tag before the tag is modified and still produce the same output expected in the test scenarios. Using copy.copy() for duplicating the tag now.

This allows all the tests to pass for me in Python 3 (on mac) using the upgraded Beautifulsoup and lxml dependencies.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.001%) to 99.558% when pulling 27516f0aee92d23648e5935a34c685bbc485251f on duplicate-tag into e3aa4bd3d1d2090d15b43002a68a41909fcfe872 on develop.

lsh-0 commented 5 years ago

Coverage decreased (-0.001%) to 99.558%

I don't know if we should tolerate such loose standards... ;)

gnott commented 5 years ago

I could add some filler to make sure the coverage percent doesn't drop - maybe next time!