Include email in JSON output for all authors.

elifesciences / elife-tools

Python library for parsing eLife article XML data.

MIT License

15 stars 7 forks source link

Include email in JSON output for all authors. #303

Closed gnott closed 5 years ago

gnott commented 5 years ago

Something discovered in issue https://github.com/elifesciences/issues/issues/4837, the emailAddresses in the JSON output for authors that are not corresponding authors are not included in the JSON output.

I think this will have no noticeable impact for eLife articles, since non-corresponding author XML doesn't include email addresses.

coveralls commented 5 years ago

Coverage remained the same at 99.558% when pulling 9e94ecff649a9cd339e71d4689a1dc400ef93480 on author-json-email into 99c5b38d5a79bdedd52a200229548d204220d864 on develop.

gnott commented 5 years ago

Feedback from Production it seems this will be ok for eLife to include all the email addresses from the XML, if they are present. When I briefly looked at the JSON schema and the eLife journal, it seemed to me the "for correspondence" in author details just looks at whether an email (or phone) is there for the author record.

We will be wanting this soon for parsing the IJM kitchen sink, so I am going to go ahead and merge this to keep things rolling.