search

elifesciences / elife-tools

Python library for parsing eLife article XML data.
MIT License
15 stars 7 forks source link

Fix render of disp-formula inside disp-quote. #330

Closed gnott closed 4 years ago

gnott commented 4 years ago

Re issue https://github.com/elifesciences/issues/issues/6136 in a recently prepared article, the <disp-formula> inside a <disp-quote> editor comment in an author response was omitted from JSON output.

In this PR test scenario is included resembling the article exhibiting the error, and the parser code is fixed to render the <p> tag inside a <disp-quote> tag properly.

Existing test cases are passing which is hopefully an indication there is minimal risk of negative consequences to rolling it out.

I tested manually converting XML to JSON for the particular article and the JSON output is valid according to the RAML schema.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.0001%) to 99.714% when pulling 3c64d9d91ac779ac8a8978da5cee432be1c88be1 on disp-formula into a5b93afbe4db7852bf1aa12265090d60140fca8e on develop.