elifesciences / elife-tools

Python library for parsing eLife article XML data.
MIT License
15 stars 7 forks source link

journal ref has no pages, do not convert to unknown. #341

Closed gnott closed 3 years ago

gnott commented 3 years ago

Re issue https://github.com/elifesciences/issues/issues/6433

Valid in api-raml version 1.1.0 https://github.com/elifesciences/api-raml/releases/tag/1.1.0

Previously, when generating JSON output for references, if a reference of type journal had no pages attribute, it was converted to type unknown, because it would not have been considered valid as a reference of type journal.

Change to the the parser here keeps them as references of type journal and no longer converts them to unknown if pages is missing.

Added another test scenario for this edge case.

Bumped library version to 0.5.0 as a result.