search

elifesciences / elife-tools

Python library for parsing eLife article XML data.
MIT License
15 stars 7 forks source link

Peer reviews #415

Closed gnott closed 1 year ago

gnott commented 1 year ago

Re eLife assessment issue https://github.com/elifesciences/issues/issues/8030 Re public reviews issue https://github.com/elifesciences/issues/issues/8031 Re epic issue https://github.com/elifesciences/issues/issues/8029

eLife is adding more types of peer review content in <sub-article> XML tags. For some of them the @article-type attribute overlaps with previously configured peer review parsing functions and they've been refactored in a mostly-backwards-compatible way.

Determining which <sub-article> is which now depends on looking for its <article-title> tag value and to match whether a term is present, or exclude it if the term is present.

To @lsh-0 please be welcome to review as you please, although I may release this in my next work day if you don't get a chance. It works, and I'm not aiming for perfection, since the test cases give me confidence it will probably satisfy the immediate needs.

lsh-0 commented 1 year ago

To @lsh-0 please be welcome to review as you please, although I may release this in my next work day if you don't get a chance. It works, and I'm not aiming for perfection, since the test cases give me confident it will probably satisfy the immediate needs.

cheers, @gnott , I'll take a look today, thanks for making it available. Everything downstream of the api-raml is much more malleable than the specification so even if we miss something here it's relatively trivial to fix it when we detect it later.

I appreciate this is like three big tickets in one

gnott commented 1 year ago

Thanks, actually also go ahead and make changes directly and push them if you want, as long as the tests pass I'm happy.