elifesciences / elife-vendor-workflow-config

capturing requriemtns and niggles for setting up the elife production workflow
0 stars 1 forks source link

ref-type=“conflict” is only used in 01328 and 01816 should be ref-type=“fn" #136

Closed Melissa37 closed 8 years ago

Melissa37 commented 8 years ago

Expected EIF: https://github.com/elifesciences/jats-scraper/blob/develop/tests/EIF/elife-01328-v1.json Failing test on Travis: https://travis-ci.org/elifesciences/jats-scraper

The problem lies with the contributor references for the competing interests normally we would expect the following xml for Randy:

            <contrib contrib-type="author" id="author-1032">
                <name>
                    <surname>Schekman</surname>
                    <given-names>Randy</given-names>
                </name>
                <xref ref-type=“fn" rid="conf1"/>
            </contrib>

But instead we have:

            <contrib contrib-type="author" id="author-1032">
                <name>
                    <surname>Schekman</surname>
                    <given-names>Randy</given-names>
                </name>
                <xref ref-type="conflict" rid="conf1"/>
            </contrib>

ref-type=“conflict” is only used in 01328 and 01816 and not other articles as far as I can tell. parseJATS.py expects the ref-type to be fn so these don’t get output as is clear from the failing test. The way forward is either to clean up the 2 xml files (which we should do anyway, if it is incorrect) or we should make parseJATS.py more tolerant to allow these values to be picked up.

gnott commented 8 years ago

Fixed now on these two articles.