search

elifesciences / elife-xpub

eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.
https://elifesciences.org/
MIT License
32 stars 5 forks source link

Missing loading spinner in Safari 12+ #1760

Open hdrury1 opened 5 years ago

hdrury1 commented 5 years ago

Describe the bug The application does not seem to utilise the loading spinner at all when using the latest version of the Safari browser in conjunction with Mojave OS. This means there is no feedback for the user when, e.g. opening the People Picker. We implemented the loading spinner as an intermediate step before we look into generally improving the People Picker's performance.

Steps To Reproduce Load the application in Safari while using the latest Mac OS. Begin a new submission and navigate to the Editors step Click a Person Pod Observe the delay in opening the People Picker Click Cancel within the People Picker Observe the delay in closing the People Picker

Expected behavior The delay is expected behaviour until we investigate wider improvements to the performance of the component. However, the loading spinner should display to the user so that they know the system is working based on their activity.

Device, Operating System and Browser Macbook Pro, Mojave OS, Safari 12.0.3

petereast commented 5 years ago

I can't reproduce this issue in BrowserStack (MacOS Mojave, Safari 12) - please could you confirm it's still a problem - the loading spinner is shown when the PeoplePicker is opening, but not when closing - is this the bug?

hdrury1 commented 5 years ago

I've just tested this live with the same setup and am not seeing the spinner in either case.

petereast commented 5 years ago

🤔

hdrury1 commented 5 years ago

Seems this in not reproducible in development, or BrowserStack and only reproducible on the live site in Safari 12/Mojave OS.

According to GA, 7% of users in the last 7 days were using this setup.

Given we're shortly going to be replacing our version of the PeoplePicker with the one shared back to PubSweet core, we should avoid touching the code until then (adding Blocked label for reference).