elifesciences / elife-xpub

eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.
https://elifesciences.org/
MIT License
32 stars 5 forks source link

npm audit issues with codebase #2136

Open diversemix opened 5 years ago

diversemix commented 5 years ago

@de-code ... commented:

BTW `npm audit fix` x2 and `npm audit fix --force` (with some minor breaking changes) had fixed it. I tried to run `npm audit` on xPub but it tripped over without any result. Still not sure how to convince GitHub to notify us. Could also run `npm audit` in PRs.

de-code commented 5 years ago

Just to clarify or provide the context, I noticed npm complaining about security issues for other repos (sciencebeam-texture and peerscout), whereas there is silence from GitHub. That is why I wanted to check whether GitHub checks are working for xPub and how I may need to change the other repos. (In my projects the package.json isn't currently in the root of the repo)

For xPub I guess the tasks could be: