EJP XML manifest items to convert: Senior editor details

Melissa37 commented 5 years ago

Problem / Motivation

WHO: Production/Bot/Production Vendor WHEN: Between Export from EJP/xPub and delivery to production vendor WHERE: In eLife bot processes WHAT: Senior editor details WHY: Differences between EJP output and final XML (EJP could not match our requirements exactly)

Proposed solution

Output from EJP: <contrib-group content-type="section"><contrib contrib-type="editor" id="author-24218"><name><surname>Frank</surname><given-names>Michael j.</given-names></name><role>Senior Editor</role><aff><institution>Brown University</institution><country>United States</country></aff></contrib></contrib-group>

Final XML: <contrib-group content-type="section"><contrib contrib-type="senior_editor"><name><surname>Frank</surname><given-names>Michael j.</given-names></name><role>Senior Editor</role><aff><institution>Brown University</institution><country>United States</country></aff></contrib> ... </contrib-group>

Differences: Final XML removed EJP ID Final XML changes @contrib-type from "editor" to "senior_editor" Final XML groups senior editor with reviewing editor in same contrib group, but in EJP they are in separate contrib groups

Clarification needed and assumptions

Is there a reason why we remove the EJP ID and should we keep it to be consistent? Yes, because the DTD does not validate if the ID is not unique in the article and as the senior editors are listed in the main article with the ID, we cannot repeat the ID below in the article stub.

Tasks

Convert the details

Technical notes

@gnott

User interface / Wireframes

NA

gnott commented 5 years ago

We recently added some logic to the elifetools JATS parser to rewrite the editor roles when they are converted to JSON format and displayed on journal. The logic to set the Senior and Reviewing Editor role might be done earlier than that as part of the packaging process.

Melissa37 commented 5 years ago

We recently added some logic to the elifetools JATS parser to rewrite the editor roles when they are converted to JSON format and displayed on journal. The logic to set the Senior and Reviewing Editor role might be done earlier than that as part of the packaging process.

But the XML stores them separately and that JSON logic is for display for the human reader and not the machine. I think it would be best to keep them separate as per the XML as that is what the vendor will supply. WDYT?

Melissa37 commented 5 years ago

Final XML removed EJP ID

Because the DTD does not validate if the ID is not unique in the article!

gnott commented 5 years ago

Not modifying the editor title / roles is fine with me - did you change the original issue definition regarding this, or maybe I just misread the details.

Melissa37 commented 5 years ago

Hi there, just updated - added a response to the clarification needed item.

elifesciences / package-ejp-raw-output-zip