elifesciences / package-ejp-raw-output-zip

Transform article raw zip files from EJP to a more consistent output.
MIT License
0 stars 1 forks source link

EJP XML manifest items to convert: Reviewing editor details #16

Open Melissa37 opened 5 years ago

Melissa37 commented 5 years ago

Problem / Motivation

WHO: Production/Bot/Production Vendor WHEN: Between Export from EJP/xPub and delivery to production vendor WHERE: In eLife bot processes WHAT: Senior editor details WHY: Differences between EJP output and final XML (EJP could not match our requirements exactly)

Proposed solution

Output from ejp: <contrib-group content-type="section"><contrib contrib-type="assoc_ed" id="author-24218"><name><surname>Frank</surname><given-names>Michael j.</given-names></name><role>Reviewing Editor</role><aff><institution>Brown University</institution><country>United States</country></aff></contrib></contrib-group>

Final XML: <contrib-group content-type="section"> ... <contrib contrib-type="editor" id="author-10"><name><surname>Collings</surname><given-names>Andy</given-names></name><role>Reviewing Editor</role><aff><institution>eLife Sciences</institution><country>United Kingdom</country></aff></contrib></contrib-group>

Differences: EJP @contrib-type is"assoc_ed"; final XML is "editor"

Clarification needed and assumptions


Tasks

Technical notes

@gnott

User interface / Wireframes

NA

gnott commented 5 years ago

I'm seeing in the input XML for what I think is an Insight article has empty tags for the editor records, I assume they can be ignored:

<contrib-group content-type="section">
<contrib contrib-type="assoc_ed" id="author-">
<name>
<surname/>
<given-names/>
</name>
<role>Reviewing Editor</role>
<aff>
<institution/>
<country/>
</aff>
</contrib>
</contrib-group>
<contrib-group content-type="section">
<contrib contrib-type="editor" id="author-">
<name>
<surname/>
<given-names/>
</name>
<role>Senior Editor</role>
<aff>
<institution/>
<country/>
</aff>
</contrib>
</contrib-group>
Melissa37 commented 5 years ago

Hi @gnott Feature content will have a whole load of their own tickets! For research articles I think this should never be empty and so this is something we'd need validation on.