elifesciences / schematron-wiki

This contains the markdown from gitbook for schematron.
MIT License
2 stars 0 forks source link

Create Decision letters/author responses page #100

Closed naushinthomson closed 4 years ago

naushinthomson commented 4 years ago

Definition of done

fred-atherden commented 4 years ago

@naushinthomson @JGilbert-eLife @bcollins14 @Melissa37, please review https://app.gitbook.com/@elifesciences/s/productionhowto/article-details/content/decision-letters-and-author-responses

I have a couple of questions:

Is that OK?

Please also note that I will fill out the 'Decision letter Word markup for JATS parsing' section once Graham has completed the kitchen sink word document.

JGilbert-eLife commented 4 years ago

(an Author response may not be included in very rare cases, but this is not the norm).

This is going to be the norm for articles reviewed on Review Commons, apparently.

JGilbert-eLife commented 4 years ago

For dec-letter-front-test-4, dec-letter-reviewer-test-1, I wonder if it's worth including a description of one common case, which is that the reviewers opted to be anonymous on the first round of review but opted to have their name revealed in a subsequent round of review. This could mean that Editorial include their name in the letter, rather than 'chose to remain anonymous', but they aren't listed in the XML because eJP only outputs non-anonymous reviewers from the full submission.

JGilbert-eLife commented 4 years ago

if it fires in live content,

I wonder if a different term would make more sense - current content? Just a bit worried that 'live' can feasibly cover any content we are working on, whether it's a new version or not.

JGilbert-eLife commented 4 years ago

Out of curiosity, why do we have rule dec-letter-reviewer-test-6 rather than just trusting the number of reviewers coming out of eJP? The cases where we have more than three aren't mistakes, after all, just alternative scenarios.

JGilbert-eLife commented 4 years ago

correct the capture of the text.

I suggest editing this to 'tag the text as boxed-text' for clarity.

JGilbert-eLife commented 4 years ago

I think for reply-missing-disp-quote-test-2, it's worth stating explicitly that if the italic text is not a quote from the decision letter, it should be tagged as a disp-quote, as the authors may include quoted paras from their article file in italics.

fred-atherden commented 4 years ago

Out of curiosity, why do we have rule dec-letter-reviewer-test-6 rather than just trusting the number of reviewers coming out of eJP? The cases where we have more than three aren't mistakes, after all, just alternative scenarios.

I don't trust eJP :smile:. Happy to remove though if it's deemed overly cautious

naushinthomson commented 4 years ago

In the 'what needs to be checked' section

There are no unaddressed Schematron messages relating to the incorrect capture of content in the Decision letter or Author response. Do we need this here? Is the understanding not that all schematron messages should be addressed where possible?

naushinthomson commented 4 years ago

Question for review - where should these be outlined? They are already explained in detail here. Should they be here instead? In Both places? Or should we just link to here?]

I think the information about why a decision letter might fail should be on this page and deleted from the managing the inbox page (but with a link added to this page).

naushinthomson commented 4 years ago

Is it worth making it clear how we verify that the DL has loaded in Kriya (just checking the dashboard)?

naushinthomson commented 4 years ago

This may be a question for the meeting but when might the DL be loaded at post-author stages? I realise you specify that this is unlikely but just wondered what scenario would lead to this :)

Screenshot 2020-08-05 at 12 56 04

naushinthomson commented 4 years ago

Re: the video loading workflow, I'm a little confused by the flow chart. The pub-check procedure seems to suggest that once Exeter has processed the videos, we send it back to Pre-editing and the DL is loaded once more, then Exeter has to be informed, then we have to verify the DL is loaded. Is that what happens (i.e. the whole process of DL loading happens again)?

Screenshot 2020-08-05 at 12 53 02

naushinthomson commented 4 years ago

For the video loading flow chart, the PAV action - should it say 'Exeter processes the video (s)' since this is an Exeter stage?

Screenshot 2020-08-05 at 12 55 08

naushinthomson commented 4 years ago

For dec-letter-front-test-4, dec-letter-reviewer-test-1, I wonder if it's worth including a description of one common case, which is that the reviewers opted to be anonymous on the first round of review but opted to have their name revealed in a subsequent round of review. This could mean that Editorial include their name in the letter, rather than 'chose to remain anonymous', but they aren't listed in the XML because eJP only outputs non-anonymous reviewers from the full submission.

This happened recently for article 53249 (and dec-letter-front-test-4 was the message that fired) if that's helpful! The reviewer's name was included in the decision letter.

naushinthomson commented 4 years ago

For dec-letter-front-test-4

Every Decision letter should have at least 1 reviewer, unless the reviewers opted to be anonymous, or if the paper was reviewed via Review commons. If this warning fires, Exeter should inform eLife Production. eLife Production should query the eLife Editorial team, asking whether Reviewers need to be included and if so, what their details are (name and optional affiliation).

Is it worth clarifying that Exeter don't need to contact us if the text 'the reviewer(s) opted to remain anonymous' or similar is present?

naushinthomson commented 4 years ago

I'm not sure why the actions for reply-missing-disp-quote-test-1 and reply-missing-disp-quote-test-2 are slightly different - should the following text be added to reply-missing-disp-quote-test-1 as well?

If it is not a quote from the Decision letter, and the text was italic in the original word document, then the text should be left as italics (a relatively common use-case is quoting from the article itself, rather than from the Decision letter).

naushinthomson commented 4 years ago

Just a general question but when we format sections of the author response letter as display quotes (e.g. if they're missed), are they automatically captured as @ content-type='editor-comment'?

naushinthomson commented 4 years ago

I think that's all from me, thanks Fred!

fred-atherden commented 4 years ago

In the 'what needs to be checked' section

There are no unaddressed Schematron messages relating to the incorrect capture of content in the Decision letter or Author response.

Do we need this here? Is the understanding not that all schematron messages should be addressed where possible?

There may be some that can be ignores. I was just trying to think of a concise way of saying that none of the messages which require action are missed. I've tried to re-phrase, but suggestions welcome.

fred-atherden commented 4 years ago

This may be a question for the meeting but when might the DL be loaded at post-author stages? I realise you specify that this is unlikely but just wondered what scenario would lead to this :)

It's quite rare, but an example that comes to hand is a major problem with the parsing of the Decision letter, which Graham has subsequently fixed, and where the simplest fix would be to re-upload the same package.

fred-atherden commented 4 years ago

Re: the video loading workflow, I'm a little confused by the flow chart. The pub-check procedure seems to suggest that once Exeter has processed the videos, we send it back to Pre-editing and the DL is loaded once more, then Exeter has to be informed, then we have to verify the DL is loaded. Is that what happens (i.e. the whole process of DL loading happens again)?

I wondered whether the flow chart would communicate what I intended. If it's not useful or if you can think of a better way to render the info then I'm happy to remove/change it (I actually went through numerous different tries and this was the best!). The X axis is meant to be interpreted as basically independent from the Y axis, except in specific cases where red lines come off actions in the X axis (revised workflows, in which case the dashed red lines should be followed).

So re your specific example it's supposed to be read:

fred-atherden commented 4 years ago

For dec-letter-front-test-4

Every Decision letter should have at least 1 reviewer, unless the reviewers opted to be anonymous, or if the paper was reviewed via Review commons. If this warning fires, Exeter should inform eLife Production. eLife Production should query the eLife Editorial team, asking whether Reviewers need to be included and if so, what their details are (name and optional affiliation).

Is it worth clarifying that Exeter don't need to contact us if the text 'the reviewer(s) opted to remain anonymous' or similar is present?

The test will no longer fire if that text is present, so that's why I left it out. Is it still necessary to include that info?

fred-atherden commented 4 years ago

Just a general question but when we format sections of the author response letter as display quotes (e.g. if they're missed), are they automatically captured as @ content-type='editor-comment'?

Yup, every display quote in the AR will have that attribute (I think this is built into Kriya).

fred-atherden commented 4 years ago

For the video loading flow chart, the PAV action - should it say 'Exeter processes the video (s)' since this is an Exeter stage?

I think we'll still need to inform them that it has videos, since I don't think that they will be notified of that in any way and they have to manually do something.

Melissa37 commented 4 years ago

All Figures, Tables, and Videos display as expected. There are no unaddressed Schematron messages which require action.

Suggest changing to:

All Figures, Tables, and Videos display expected to display in the same way as in main article.

Melissa37 commented 4 years ago

The word document containing both the Decision letter and Author response, and any accompanying assets are zipped up, and placed in the elife/decision-letter-input AWS bucket by the eLife Editorial team.

Suggested changes:

The Word document, which contains both the Decision letter and Author response, along with any accompanying assets, are zipped up and placed in the elife/decision-letter-input AWS bucket by the eLife Editorial team.

Melissa37 commented 4 years ago

In the event that a Decision letter/Author response contains videos, Editorial will inform Production prior to uploading, see below on what to do when this occurs workflow.

Suggest adding "in the" before workflow at the end.

Melissa37 commented 4 years ago

See below for the workflow https://docs.google.com/drawings/d/1mN7lHDMwa2CWaMSoR8q1xHiuvDzY3y3iOGdG9UKUVTc/edit

Wow, this looks really complicated!!

Melissa37 commented 4 years ago

Action: This will fire is a paragraph in a Decision letter or Author response contains the text </author response or similar. This type of pseudo-code is included in the original Word document by the eLife editorial team as flags for the decision-letter-parser to correctly recognise what a certain object in the document should be captured as. If this text is in the JATS, however, that means that the content has not been correctly recognised by the parser. Exeter should flag this error with the eLife production team.

Should the pseudo code have a close bracket on it?

Melissa37 commented 4 years ago

If this warning fires, Exeter should inform eLife Production. eLife Production should query the eLife Editorial team, asking whether Reviewers need to be included and if so, what their details are (name and optional affiliation).

Needs comma before "if so" as well as after it

Melissa37 commented 4 years ago

The eLife production team should check the article in eJP (it might be that the editor details were added subsequent to the article being exported to Kriya). If the information is not available in eJP, then this should be queried with the eLife Editorial team in order to get the details for the the Reviewing Editor (name and affiliation - both are mandatory).

double "the" - remove one

fred-atherden commented 4 years ago

The Word document, which contains both the Decision letter and Author response, along with any accompanying assets, are zipped up and placed in the elife/decision-letter-input AWS bucket by the eLife Editorial team.

I think this wording implies that the assets are included in the word document, which is not the case and is the reason for the original clunky wording.

fred-atherden commented 4 years ago

Action: This will fire is a paragraph in a Decision letter or Author response contains the text </author response or similar. This type of pseudo-code is included in the original Word document by the eLife editorial team as flags for the decision-letter-parser to correctly recognise what a certain object in the document should be captured as. If this text is in the JATS, however, that means that the content has not been correctly recognised by the parser. Exeter should flag this error with the eLife production team.

Should the pseudo code have a close bracket on it?

It will fire even if there isn't a closed bracket (which might the cause of the issue in the first place). I have also included an example with a closed bracket in the action.

Melissa37 commented 4 years ago

Unicode tests

I wonder whether we should say something along the lines of "if there are lots of these schematron warnings production can send the article back to Exeter to fix them all?

Melissa37 commented 4 years ago

Error: sub-article id must be in the format 'sa0', where '0' is it's position (1 or 2).

it's should be its ?

Melissa37 commented 4 years ago

Error: sub-article contain one and only one front-stub. Error: sub-article contain one and only one body.

Should be "sub article contains" in both places

bcollins14 commented 4 years ago

Would author response images mislabelling be counted on this page? Typically when they forget the . at the end.

bcollins14 commented 4 years ago

Other than that, everyone has covered everything. I loved the diagrams and the information boxes.

fred-atherden commented 4 years ago

Would author response images mislabelling be counted on this page? Typically when they forget the . at the end.

I think that would be covered here