Update Tables page - Githubissues

elifesciences / schematron-wiki

This contains the markdown from gitbook for schematron.

MIT License

2 stars 0 forks source link

Closed eLifeProduction closed 4 years ago

eLifeProduction commented 4 years ago

[x] Add Inline images in tables section to page
[x] Link out from figures page - under 'Unlabelled images in the article file', add the sentence 'Inline images may also be present within tables - for more about this, see here.' before the final sentence of the first paragraph.
[x] Add schematron message and action about titles of appendix tables ending in fullstops.
[x] Becky approved page
[x] Melissa approved page
[x] Fred approved page
[x] James approved page
[x] Naushin approved page
[ ] Share page with Exeter if relevant

fred-atherden commented 4 years ago

@bcollins14, @naushinthomson, @JGilbert-eLife, @Melissa37, I've updated this page with a small section on inline images. Any further information need adding here? https://elifesciences.gitbook.io/productionhowto/-M1eY9ikxECYR-0OcnGt/article-details/content/allowed-assets/tables#inline-images

Melissa37 commented 4 years ago

Looks good to me

JGilbert-eLife commented 4 years ago

@FAtherden-eLife Have you yet to add some of the images, or have they been lost somehow? I think I'm only seeing one out of three (?).

Otherwise, looks good.

fred-atherden commented 4 years ago

@JGilbert-eLife, sorry not sure i understand the question. Do you want me to add images of the tables in that section?

JGilbert-eLife commented 4 years ago

This bit seems to be missing images referred to in the text, but there wasn't anything in your initial comment about still needing to add images:

Screen Shot 2020-09-08 at 12 19 01

fred-atherden commented 4 years ago

The 'Here' text is linked to examples. I will also add images, since it seems that's unclear.

JGilbert-eLife commented 4 years ago

Ah, sorry! Yes, that's really obvious and I can only plead having a hard time distinguishing bold text in GitBook today.

I do think images would help, though, following the pattern elsewhere.

fred-atherden commented 4 years ago

No problem - also agree that we should be consistent if that's what's been done elsewhere. I've added the images.

naushinthomson commented 4 years ago

Looks good to me!

bcollins14 commented 4 years ago

Looks good to me also, thanks!