Update RRID page - Githubissues

elifesciences / schematron-wiki

This contains the markdown from gitbook for schematron.

MIT License

2 stars 0 forks source link

Update RRID page #161

Closed naushinthomson closed 2 years ago

naushinthomson commented 3 years ago

[x] Add updates to page about using identifiers.org instead of scicrunch resolver (see here for gitlab ticket)
[ ] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Share page with Exeter if relevant

Definition of done

[ ] Team reviewed and approved page?
[x] Add changelog to page
[x] Assign Fred to update the Schematron if relevant

fred-atherden commented 3 years ago

Please also add this new Schematron test addgene-test.

Melissa37 commented 2 years ago

@FAtherden-eLife I've updated the text and it looks like the identifiers.org url no longer needs the RRID/ anymore, eg: https://identifiers.org/RRID:AB_2178887

That means this warning needs updating (any maybe the test in the Schematron too)?

Warning: 'XXXXXX' element contains what looks like XXXXXX unlinked RRID(s). These should always be linked using 'https://identifiers.org/RRID/RRID:'. Element begins with XXXXXX.

Can these be updated to remove the "(scicrunch)":

Error: RRID (scicrunch) link should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Warning: RRID (scicrunch) link should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Melissa37 commented 2 years ago

@FAtherden-eLife

Please also add this new Schematron test addgene-test.

This mentions https://scicrunch.org/resolver/RRID:addgene{number} link in the warning. Should this be updated to 'https://identifiers.org/RRID/:addgene{number}

Melissa37 commented 2 years ago

@FAtherden-eLife I've updated the text and it looks like the identifiers.org url no longer needs the RRID/ anymore, eg: https://identifiers.org/RRID:AB_2178887

That means this warning needs updating (any maybe the test in the Schematron too)?

Warning: 'XXXXXX' element contains what looks like XXXXXX unlinked RRID(s). These should always be linked using 'https://identifiers.org/RRID/RRID:'. Element begins with XXXXXX.

Can these be updated to remove the "(scicrunch)":

Error: RRID (scicrunch) link should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Warning: RRID (scicrunch) link should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Whoops, sorry, it should be: 'https://identifiers.org/RRID:

You Ok to update again.

Melissa37 commented 2 years ago

@FAtherden-eLife I've updated the page and merged it to live. Hope that's OK? I won't close this ticket until I know you have done the text changes to your messages in Schematron:

Warning: 'XXXXXX' element contains what looks like XXXXXX unlinked RRID(s). These should always be linked using 'https://identifiers.org/RRID:'. Element begins with XXXXXX.

Error: RRID link should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Warning: RRID ink should be preceded by 'RRID:' with no space but instead it is preceded by 'XXXXXX'.

Warning: td element containing - 'XXXXXX' - looks like it contains an addgene number. Should this be changed to an RRID with a https://identifiers.org/RRID:addgene{number} link?

fred-atherden commented 2 years ago

@Melissa37, yup - that's great thanks - I'll reassign.