search

elifesciences / schematron-wiki

This contains the markdown from gitbook for schematron.
MIT License
2 stars 0 forks source link

Update Software references page #193

Closed naushinthomson closed 2 years ago

naushinthomson commented 3 years ago

Definition of done

fred-atherden commented 3 years ago

There's also gitlab-no-citation, which is the same but for gitlab mentions.

naushinthomson commented 2 years ago

@FAtherden-eLife This has now been done, does the action look ok? If so can you update the schematron links? Thanks!

fred-atherden commented 2 years ago

Thanks @naushinthomson.

Re this:

This can be ignored if the GitHub link has been saved in Software Heritage (see here for more about this).

The warning shouldn't fire if this was the case. If a SWH citation has been added, the link in the reference should be in long form (the directory link), meaning that the GitHub repo would be contained within it. The way this test works means that if that has happened, then it wouldn't fire, even if it was pointing to a specific file/line of code within the repo.

The action is fine, just the sentence above needs removing from gitlab-no-citation and github-no-citation.

naushinthomson commented 2 years ago

@FAtherden-eLife I've updated the text as suggested now! :)

fred-atherden commented 2 years ago

Thanks!