Add rails4 compability

[markevich]

Adding of separate branch will be welcome.

42

[elight]

<3 thanks.

Yes, we need a Rails 4 branch. I'll add it to my todo list.

On Thu, Mar 28, 2013 at 7:26 PM, Slava Markevich notifications@github.com wrote:

Adding of separate branch will be welcome.

42

You can merge this Pull Request by running: git pull https://github.com/markevich/acts_as_commentable_with_threading rails4 Or you can view, comment on it, or merge it online at: https://github.com/elight/acts_as_commentable_with_threading/pull/44 -- Commit Summary --

• change source to rubygems
• bump gem versions
• ActiveRecord relation now return ActiveRecord::Relation instance.
• Lock gem versions.
• Refresh Gemfile.log -- File Changes -- M Gemfile (19) M Gemfile.lock (163) M spec/commentable_spec.rb (2) -- Patch Links -- https://github.com/elight/acts_as_commentable_with_threading/pull/44.patch https://github.com/elight/acts_as_commentable_with_threading/pull/44.diff

[elight]

Manually merged into rails4 branch. Thanks!

[elight]

Default rake task doesn't work now. :-(

Though I can run "rspec" to get the specs to run.

[jerome]

Hello. Doesn't work for rails 4.0.0 rc1 :( - Best

[elight]

Can you elaborate? Backtrack?

On Sun, May 19, 2013 at 2:28 PM, Jérôme Lipowicz notifications@github.com wrote:

Hello. Doesn't work for rails 4.0.0 rc1 :( - Best

Reply to this email directly or view it on GitHub: https://github.com/elight/acts_as_commentable_with_threading/pull/44#issuecomment-18117631

[jerome]

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    acts_as_commentable_with_threading (>= 0) ruby depends on
      activesupport (~> 3.0) ruby

    rails (~> 4.0.0rc1) ruby depends on
      activesupport (4.0.0.rc1)

Using

gem 'acts_as_commentable_with_threading', git: 'http://github.com/elight/acts_as_commentable_with_threading.git', branch: 'rails4'

[ccfiel]

same here

[D1plo1d]

Patched this, see https://github.com/elight/acts_as_commentable_with_threading/pull/48

[ghost]

@ jerome same here ,can't work on rails4

[1dolinski]

same here.. any update on this?

Bundler could not find compatible versions for gem "activesupport": In Gemfile:

acts_as_commentable_with_threading (>= 0) ruby depends on
      activesupport (~> 3.0) ruby

rails (= 4.0.0.beta1) ruby depends on
  activesupport (4.0.0.beta1)