search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
671 stars 168 forks source link

Rails 4 Support w/Travis Integration #50

Closed petergoldstein closed 11 years ago

petergoldstein commented 11 years ago

i) Updated a Rails 4 failing spec to be Rails 4 compatible ii) Updated rspec to use a more modern version of rspec iii) Updated the Rakefile to work with the updated toolchain iv) Added gemfile and a .travis.yml to test against Rails 3.0.x, 3.1.x, 3.2.x and 4.0.x

climatecheck commented 11 years ago

:shipit: !

coderberry commented 11 years ago

This would be great to merge @elight :dancer:

csoare7 commented 11 years ago

Any plans on fixing the rails 4 issue and merging this?

coderberry commented 11 years ago

nudge @elight

umhan35 commented 11 years ago

+1 @elight

elight commented 11 years ago

I'm alive. My life is just a bit more complex than many. I haven't merged this outright because I want to run the tests against Rails 3.2 and 4.0 and ensure all is well. Soon. I haven't forgotten.

markpoon commented 11 years ago

thanks @elight we appreciate it, would you mind updating us on the status of the tests? Thanks!

mikeatlas commented 11 years ago

+1 @elight thanks

elight commented 11 years ago

Loooong overdue.

petergoldstein commented 11 years ago

@elight Thanks for merging. If you haven't already, you may want to go to travis-ci.org and enable CI builds for this repo. Should work now that there's a .travis.yml file.

elight commented 11 years ago

Will do.

Also double-checking this locally and trying to push a version bump out.

elight commented 11 years ago

@petergoldstein Thanks again. I'm ashamed to say that it's been maybe a year since I've done anything with Travis. This will be a big help!

elight commented 11 years ago

Does some brave soul out there (@petergoldstein) want to try the new version in master against Rails 4 and report back?

Travis is happy. Though Rails 4 barfs out a bevvy of deprecation warnings now against aacwt.

markpoon commented 11 years ago

Rejoice!

elight commented 11 years ago

❤️

To say my life has been "complex" would be grossly understating facts. But that's changed now. I don't expect to see a backlog of Issues here again like we had anytime soon

— Sent from Mailbox for iPhone

On Fri, Nov 15, 2013 at 6:45 PM, Mark Poon notifications@github.com wrote:

Rejoice!

Reply to this email directly or view it on GitHub: https://github.com/elight/acts_as_commentable_with_threading/pull/50#issuecomment-28612949

archonic commented 11 years ago

You're the man @elight. Hope everything is smooth sailing for you now!

mikeatlas commented 10 years ago

Are there still deprecation warnings being emitted as a result of the rails 4 support? I had previously forked this on my own to update the gemspecs and haven't seen any deprecation warnings in my fork... my goal is to be running on rails4 entirely without any warnings.

elight commented 10 years ago

Yep. (another) pull request perhaps? Thanks. On Nov 18, 2013 11:18 AM, "Mike Atlas" notifications@github.com wrote:

Are there still deprecation warnings being emitted as a result of the rails 4 support? I had previously forked this on my own to update the gemspecs and haven't seen any deprecation warnings in my fork... my goal is to be running on rails4 entirely without any warnings.

— Reply to this email directly or view it on GitHubhttps://github.com/elight/acts_as_commentable_with_threading/pull/50#issuecomment-28711943 .

petergoldstein commented 10 years ago

@elight I submitted PR #53 three days ago to address the deprecation warnings.

elight commented 10 years ago

I'll check it out. Thanks! On Nov 18, 2013 12:02 PM, "Peter Goldstein" notifications@github.com wrote:

@elight https://github.com/elight I submitted PR #53https://github.com/elight/acts_as_commentable_with_threading/pull/53three days ago to address the deprecation warnings.

— Reply to this email directly or view it on GitHubhttps://github.com/elight/acts_as_commentable_with_threading/pull/50#issuecomment-28716354 .

elight commented 10 years ago

Merged #53. Thanks @petergoldstein