search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
671 stars 168 forks source link

Address Rails 4 deprecation warnings #53

Closed petergoldstein closed 10 years ago

petergoldstein commented 11 years ago
  1. Update Rails 4 versions to use 3.0.x branch of awesome_nested_set.
  2. Fix bad rspec version in Gemfile
petergoldstein commented 11 years ago

While the 2.x branch of awesome_nested_set may work with Rails 4, the intention is for the 3.x branch to be used in Rails 4 apps. Updated the Gemfiles to reflect this, which fixed all the deprecation warnings in the specs.

mikeatlas commented 10 years ago

+1

mikeatlas commented 10 years ago

I haven't dug in but the deprecation warnings I fixed were about the new scope syntax as well as upgrading awesome_nested_set.

https://github.com/mikeatlas/acts_as_commentable_with_threading/commits/master