search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
671 stars 168 forks source link

Version Error on awesome_nested_set #73

Closed cranesandcaff closed 10 years ago

cranesandcaff commented 10 years ago

https://github.com/collectiveidea/awesome_nested_set/issues/246

Looks like this gem is dependent on awesome_nested_set version 2, version 3 includes a fix for rails 4.1.

CoincoinNico commented 10 years ago

Hello there ! I'm new to Rails but encounter the same issue. There is no way to solve it then or forcing the gem to a newer version would do the trick ? Best

cranesandcaff commented 10 years ago

I'm new to Ruby/Rails as well but I believe you can fork this and update the dependency, then use your forked version as well as put in a pull request and then @elight can merge in the update assuming it doesn't brick anything.

CoincoinNico commented 10 years ago

Thanks. I just updated from scratch my comment models using polymorphism and adding ajax, I prefer this when beginning, i understand more the mechanics. Too bad there is no tuto for these gems in Rails 4 !

2014-05-29 17:27 GMT+02:00 cranesandcaff notifications@github.com:

I'm new to Ruby/Rails as well but I believe you can fork this and update the dependency, then use your forked version as well as put in a pull request and then @elight https://github.com/elight can merge in the update assuming it doesn't brick anything.

— Reply to this email directly or view it on GitHub https://github.com/elight/acts_as_commentable_with_threading/issues/73#issuecomment-44544781 .

vinnividivicci commented 10 years ago

@cranesandcaff I applied your patch idea and it works. If you use https://github.com/vinnividivicci/acts_as_commentable_with_threading in your Gemfile: gem 'acts_as_commentable_with_threading', git: "https://github.com/vinnividivicci/acts_as_commentable_with_threading.git" then run: bundle update It should start working again.

vinnividivicci commented 10 years ago

@cranesandcaff @CoincoinNico See pull request https://github.com/elight/acts_as_commentable_with_threading/pull/76 for an even better solution!

petergoldstein commented 10 years ago

Closing this, as Rails 4.1 users simply need to explicitly include

gem 'awesome_nested_set', '>= 3.0'

in their application's Gemfile. The acts_as_commentable_with_threading master is compatible with any awesome_nested_set version greater than 2.0.