search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
672 stars 167 forks source link

Fix "ArgumentError: Unknown key: :order" with Rails 4.1 #76

Closed vinnividivicci closed 10 years ago

vinnividivicci commented 10 years ago

This pull request would fix the incompatibility issue with Rails 4.1+ described here: https://github.com/collectiveidea/awesome_nested_set/issues/246 and here: https://github.com/elight/acts_as_commentable_with_threading/issues/73

petergoldstein commented 10 years ago

@vinnividivicci This change breaks all Rails compatibility below 4.0 - unnecessarily so. There's no reason to alter the gemspec for what amounts to an awesome_nested_set/Rails 4.1 incompatibility.

Just use a Rails 4.1 compatible version of awesome_nested_set in your Gemfile in your app and everything will work fine.

vinnividivicci commented 10 years ago

@petergoldstein Agreed, I like your solution better, didn't realize I could do that! Thanks for the update! Confirmed as working on my project.

cranesandcaff commented 10 years ago

I also did not know this was possible. Thanks