search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
672 stars 167 forks source link

Version 2.0.0 / Rails 4+ changes #86

Closed petergoldstein closed 9 years ago

petergoldstein commented 10 years ago
  1. Updated dependencies so that we support Rails 4+ only.
  2. Bumped version to 2.0.0
  3. Neatened up Gemfiles so they only contain required lines and delegate to the gemspec.
  4. Fixed use of 'http://rubygems.org' in Gemfiles
  5. Updated CHANGELOG and moved to Markdown.
  6. Fixed deprecation warnings in specs.
  7. Removed Rails 3.x gemfiles and Travis entries.

@elight Can you review these changes? Once they're merged to master it probably makes sense to push a gem to Rubygems, unless there's anything else you think should go in 2.0.0

petergoldstein commented 9 years ago

@elight Ping.

If you can review we can merge and push out a new gem.

petergoldstein commented 9 years ago

@elight I'm happy to merge this in as is if you don't want to review it. But I can't push out a new gem version without your assistance. Please let me know how I can help move this to completion. Thanks.

elight commented 9 years ago

Looks good to me.

I apologize. This is long overdue: http://cl.ly/image/3k2E2i093x30

petergoldstein commented 9 years ago

@elight Thanks much. I'll merge this now and should be able to release a new gem version tonight.