search

elight / acts_as_commentable_with_threading

Similar to acts_as_commentable; however, utilizes awesome_nested_set to provide threaded comments
MIT License
672 stars 167 forks source link

Add Rails 5 support #93

Closed halostatue closed 8 years ago

halostatue commented 8 years ago
halostatue commented 8 years ago

I will not have time to split this into separate PRs before the new year—only a couple of days before I head out on vacation and many other things to do. This was added as an experimental change to get a private app working with Rails 5 (and there are ~4 other gems that need patching, so I whipped a bunch of these off quickly without tons of attention).

The only change that is required is in lib/acts_as_commentable_with_threading.rb:31. Everything else is ceremony.

petergoldstein commented 8 years ago

Ok, I moved the critical change to another PR and merged it.

petergoldstein commented 8 years ago

So I merged the other PR and released a patch version (2.0.1). I'd like to deal with the rest of these changes (Travis for Rails 5.x) in a separate PR, so I'm going to close this one. But thanks for raising the issue!

halostatue commented 8 years ago

Thanks for following through on this!