Closed mitar closed 10 years ago
Why close without merge?
Uint8Array
commit: The older versions did append [ArrayBufferView].buffer
but that is no longer the case due to the newer Blob APIview = this/this.self/this.window
was the cause of multiple issues affecting FileSaver.js and Blob.js in various non-browser contexts. Changing it to this
will re-break stuff@mitar Thank you! I used your latest commit's version of Blob.js and my tests seem to be passing!
@eligrey I am using Blob.js exactly in the non-browser contexts. This is why this changes are needed.
@mitar if @eligrey wants this to be more about browsers you should just rename your fork like PhantomBlob so it's easier to find. I saw this repo but couldnt figure out why it still wasnt working until I dug into the PRs.
@mitar Go ahead and follow @OscarGodson's advice about making a PhantomBlob fork. I won't be supporting that old WebKit version and if you do want to use it, you probably don't need this code anyways, as an old BlobBuilder.js should work.
@eligrey I am using Blob.js exactly in the non-browser contexts. This is why this changes are needed.
As I suggested previously, first try using older BlobBuilder.js (not Blob.js) versions and report back before renaming your fork.
Fixed some issues with Blob.js running on PhantomJS, that is, a quite old version of WebKit.