eligrey / Blob.js

An HTML5 Blob implementation
Other
1.15k stars 605 forks source link

Undefined variable: Uint8Array #58

Closed NeilFraser closed 6 years ago

NeilFraser commented 6 years ago

This line appears to be checking if Uint8Array exists: https://github.com/eligrey/Blob.js/blob/3eca1d01c802acd6fb02def446dab87191200a15/Blob.js#L192

However my reading of it is that if Uint8Array doesn't exist, the JS runtime would throw an undefined variable error. Did you mean to use typeof?

eligrey commented 6 years ago

Uint8Array is defined here: https://github.com/eligrey/Blob.js/blob/3eca1d01c802acd6fb02def446dab87191200a15/Blob.js#L64

If you have any other questions feel free to submit additional issues. Cheers!