eligrey / Blob.js

An HTML5 Blob implementation
Other
1.15k stars 605 forks source link

Compatibility overhaul #67

Closed jimmywarting closed 5 years ago

jimmywarting commented 5 years ago

Sorry for such a big commit/change... would rather want to do smaller PR and many PR, but it often result in things taking longer for things to be accepted and merged...


When stream, arrayBuffer and text was announced i started to look back into node-fetch to try and implement dose functionalities... And they are there now.

But node-fetch is looking into extracting out there own Blob implementation and use a third-party blob implementation instead, figured instead of creating yet another module we could use something that already exist. so i looked back into your Blob.js implementation.

If node-fetch is ever going to use your version of blob.js then there are a few things that needs to happen before we even consider it. And that is what this PR is solving.

closes #65 closes #66

jimmywarting commented 5 years ago

the new methods require promises and readableStream but I thing that is beyond the scope of blob.js They should include stream and promise polyfills themself if they need to

eligrey commented 5 years ago

Thank you!