elijah-potter / harper

The Grammar Checker for Developers
https://writewithharper.com
Apache License 2.0
743 stars 22 forks source link

Feat: Add harper-ls to Zed #114

Open MahanRahmati opened 3 weeks ago

MahanRahmati commented 3 weeks ago

Hello there! Thank you for creating this nice checker! Can you add it to Zed? You can check the documentation of Zed for creating extensions here.

Stef16Robbe commented 1 week ago

Hi, I'm working on this. (non-functional) code can be found here: https://github.com/Stef16Robbe/harper_zed

Still need some help with configuring the extension so I opened a discussion for anyone interested: https://github.com/zed-industries/zed/discussions/17344

elijah-potter commented 1 week ago

@Stef16Robbe Thanks for picking this up! Just to be clear, Harper doesn't support all programming languages yet. You can use nvim-lspconfig as a reference.

Stef16Robbe commented 1 week ago

That makes... a lot more sense 😅. Thanks for mentioning! In that case I know how to continue ^^.

Stef16Robbe commented 1 week ago

So 0.0.1 is working when harper-lsp is preinstalled, working making sure that the extension will do that as a backup when needed. After that I'll create a PR to zed repo to get it added in the list of extensions

elijah-potter commented 1 week ago

That's fantastic news! Keep us updated as to when you've got everything working.