search

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.
Apache License 2.0
52 stars 93 forks source link

Update binary.rb #26

Closed tuahk closed 9 years ago

tuahk commented 9 years ago

Added support for different tar files and made the changes that were suggested by ewr.

rayrod2030 commented 9 years ago

These changes look good. I take it that these changes will upgrade the running prometheus binary if the user defines a newer version in the attributes?

tuahk commented 9 years ago

Yup, if you change version attribute to something that your node hasn't yet used, then it will extract that file and update binary. At least to my understanding and testing.

However, if you want to change back to version you used to use, then there already exists a tar file and extract does not get notified, so binary stays in previous version. Should it be possible to change back to previous version?

I actually think we might want to start using this cookbook https://github.com/burtlo/ark to handle binary installation?

rayrod2030 commented 9 years ago

Yes absolutely I always forget about ark. It's definitely the way to go there.

tuahk commented 9 years ago

Great! I'll make other PR today or tomorrow which uses ark.