search

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.
Apache License 2.0
52 stars 93 forks source link

Allow external management of prometheus.conf #30

Closed ewr closed 9 years ago

ewr commented 9 years ago

So just after we merged #22, allowing easier configuration, I'd now like a change that takes this cookbook out of the config business.

Context is in prometheus/prometheus#608. Basically the existing service discovery isn't quite doing what I need it to because of a detail in how Consul implements SRV lookups. Until we get that sorted I plan to use consul-template to make sure all my nodes get written into the config correctly.

To do that, though, I need this cookbook to not care that my external process is writing a new config file. This seems like a fairly normal case (a wrapper cookbook that is opinionated about how the config gets created), so I think both config cases help expand what the cookbook can do.

rayrod2030 commented 9 years ago

I fixed that issue with that spec so if you merge master your PR should pass.

rayrod2030 commented 9 years ago

And as far as this change I'm all for it. I'll be spending some time on the README to explain all of these options for the next release.

ewr commented 9 years ago

Cool. Did the merge, and I've updated our wrapper cookbook to start using this successfully.

ewr commented 9 years ago

Thanks! :+1: