search

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.
Apache License 2.0
52 stars 93 forks source link

Prometheus config format switched from ASCII protobufs to YAML #34

Closed gbagnoli closed 7 years ago

gbagnoli commented 9 years ago

PR: https://github.com/prometheus/prometheus/pull/680 Here the announcement on the mailing list

Judging by the commit history on the github page, versions after 0.13.3 (https://github.com/prometheus/prometheus/commit/43b41c56ce469cdaa94447541693578c5ec16a91) are using the new yaml config format.

Currently the source installation method is broken, binary works as the binary itself is old (the sourceforge page says it has been updated on 2015-03-18)

unbrice commented 9 years ago

Would you accept a PR that would drop support of versions <= 0.13.3 in favor of versions >=0.14, hardcoding the use of the new format? The target configurable settings - among other things - has changed a bit. Supporting only newer versions going forward removes the need of a common configuration abstracting away the changes. Users of older Prometheus versions could still use older versions of the recipe until they upgrade.

rayrod2030 commented 9 years ago

@unbrice Yes absolutely I think the best solution would be to support >=0.14 as there have been lots of changes. Would totally welcome a PR as I haven't had as much time as I'd like to have had to upgrade this cookbook.