Add additional init styles

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.

Apache License 2.0

52 stars 93 forks source link

Add additional init styles #4

Closed rayrod2030 closed 9 years ago

rayrod2030 commented 9 years ago

In addition to supporting runit this cookbook should support other init styles such as:

[x] SysV Init.d - started in https://github.com/rayrod2030/chef-prometheus/pull/16
[x] Upstart - started in https://github.com/rayrod2030/chef-prometheus/pull/35
[x] Systemd - started in https://github.com/rayrod2030/chef-prometheus/pull/25
[x] Bluepill - started in https://github.com/rayrod2030/chef-prometheus/pull/14

tuahk commented 9 years ago

Good idea. There is a cookbook for Bluepill and a service for Upstart so I can start by adding support for those two.

rayrod2030 commented 9 years ago

Yeah I'm going to try to knock out at least SysV init and upstart using the nginx cookbook as inspiration.

tuahk commented 9 years ago

It seems like the same string of flags is needed in all of the different init-erb files. So how would you feel if I moved the code generating 'config' string in sv-prometheus-run.erb to libraries/help_functions.rb? Or do you happen to have some other idea how not to write the same code in multiple erb files?

tuahk commented 9 years ago

Seems like we both said that we are going to add support for upstart. To avoid duplicate work we probably should decided who is doing this. I could start working on this as soon as I have time but if this is something you want to implement then I can move on to pre-compailed binary installation?