Alertmanager: Templatize config, user, and url.

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.

Apache License 2.0

52 stars 93 forks source link

Alertmanager: Templatize config, user, and url. #79

Closed pop closed 7 years ago

pop commented 7 years ago

@mburns @elijah (at any other maintainers)

This Pull Request adds the ability to template the http url, config destination, and user of the alert manager service(s).

Let me know if there's any edits I should make before it can be merged -- or if there are any fundamental problems with it being added in the first place. Like maybe we should add tests. Tests are cool. 😄

pop commented 7 years ago

I edited the .rubocop.yml config so it should conform with our coding standards, meaning we can run rubocop -c .rubocop.yml locally and it matches what houndci will complain about. I was just running rake spec travis:ci and it didn't hit any of those warnings.

Anyway, I also added a bunch of tests and fixed up the code a bit @MarkGibbons and @elijah (plus other contributors) so please let me know what else I can do to get this merged.

elijah commented 7 years ago

Merged. Thank you for all the work, and for the attention to tests and code style conventions!