search

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.
Apache License 2.0
52 stars 93 forks source link

Add chefspecs to test source.rb #8

Closed tuahk closed 9 years ago

tuahk commented 9 years ago

Here is something we can start building upon. It passes both rubocop and foodcritic tests.

rayrod2030 commented 9 years ago

Thanks for these specs and these look like a good start. In the meantime I'll get this cookbook set up with houndci for syntax comments and travis for running chefspec's.

rayrod2030 commented 9 years ago

@tuahk Looks like houndci isn't respecting out rubocop settings for string quotation. Ignore these warnings for now until we can get it sorted out.

rayrod2030 commented 9 years ago

@tuahk It's probably because your branch doesn't have the latest .hound.yml file which references our rubocop file. Try to add that file to your PR. It's here: https://github.com/rayrod2030/chef-prometheus/blob/master/.hound.yml

tuahk commented 9 years ago

Ok, I'll do that

rayrod2030 commented 9 years ago

Looks good. Merging and thank you!