search

elijah / chef-prometheus

Chef cookbook for Prometheus. The open source service monitoring system and time-series database.
Apache License 2.0
52 stars 93 forks source link

resources/job: respect allow_external_config flag #81

Closed pop closed 7 years ago

pop commented 7 years ago

@elijah There the allow_external_config flag's behavior was deprecated but the flag was not removed. I figure the removal was an accident so this adds it back in.

I tried adding a test for this in the future but I'm not sure the best way to go about it, chefspec doesn't like asking if the prometheus_job resource has created a template. Let me know if you've got any ideas.

elijah commented 7 years ago

merging. Seems good to me.