Wrapper cookbook fixes

[lamont]

This solves issue #89 and adds a unit test for same. Essentially I removed any mention of the cookbook source from the custom job resource so that the attribute-set value in the original template definition won't be pointlessly overwritten.

I also applied all the cookstyle recommended fixes.

[lamont]

Travis is failing for reasons I don't understand (kitchen is complaining about a missing cookbook dependency on apt that is clearly there in metadata.rb, plus my local kitchen-vagrant worked). I'm going to keep digging at this, but I'd appreciate a heads up from @elijah or similar saying that I should continue working on getting this PR to pass hound AND travis vs resetting it to just the original unit test and custom resource changes.

[elijah]

Do your best, but... i am not sure Travis is particularly reliable of late.

--elijah

On Feb 26, 2018 10:45 AM, "lamont" notifications@github.com wrote:

Travis is failing for reasons I don't understand (kitchen is complaining about a missing cookbook dependency on apt that is clearly there in metadata.rb, plus my local kitchen-vagrant worked). I'm going to keep digging at this, but I'd appreciate a heads up from @elijah https://github.com/elijah or similar saying that I should continue working on getting this PR to pass hound AND travis vs resetting it to just the original unit test and custom resource changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elijah/chef-prometheus/pull/91#issuecomment-368605308, or mute the thread https://github.com/notifications/unsubscribe-auth/AACok5yKq9rSXt_eFFteKquRYyK5pqumks5tYvuvgaJpZM4SSupy .

[lamont]

Boom, travis fixed! I just updated the Gemfile to some latest stuff. I also got a good pointer from Dan Webb on the community chef slack and will open a new PR to use the latest, blessed version of https://github.com/chef-cookbooks/aws/blob/master/.travis.yml which lets us do kitchen via dokken.

Assuming you're happy with this PR (so green!) please merge and version as you see appropriate.

[lamont]

Sorry to bother, but I'd like to get a ruling on this PR and merge it if you agree it fixes the issue. It does solve the unit test I added at least, and I got kitchen working again. @elijah are you the party I should ask?

[elijah]

Merged. ;-)