Credits view should be HTML or Text View

[GoogleCodeExporter]

With external links leading to Safari to avoid 17+ rating

Original issue reported on code.google.com by din...@gmail.com on 7 Aug 2009 at 6:28

[GoogleCodeExporter]

I have a string of patches cleaning up the code (IMO, of course), which 
includes 
converting the credits to an HTML file. I am not sure how to go about providing 
such 
large contributions though.

Original comment by ciawal@gmail.com on 8 Aug 2009 at 12:12

[GoogleCodeExporter]

In your Html view, do external links invoke safari? If yes, please send me a 
patch or
attach it here (would like to have a final look) and if it looks ok will add 
you as
contributor so you can commit it.

Original comment by din...@gmail.com on 8 Aug 2009 at 6:07

[GoogleCodeExporter]

This is how I handle local and external links in my HTML help/credits file for 
Rogue Touch, if it helps you:

- (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest 
*)request 
navigationType:(UIWebViewNavigationType)navigationType {

    // if we click a chronosoft link, direct them to safari!
    BOOL match = ([[request.URL absoluteString] rangeOfString:@"chronosoft" 
options:NSCaseInsensitiveSearch].location != NSNotFound);

    if (navigationType == UIWebViewNavigationTypeLinkClicked && match) {
        [[UIApplication sharedApplication] openURL:request.URL];
        return NO;
    }
    return YES;
}

You should be able to adapt that to your needs easily, or even invert it so 
that anything that doesn't target a 
local anchor to self goes to Safari. 

Original comment by kevinh...@gmail.com on 8 Aug 2009 at 1:49

[GoogleCodeExporter]

The patch won’t apply cleanly as it’s based upon prior commits. I’ll try 
to extract 
a single patch which does as little as possible to fix this issue though.

Original comment by ciawal@gmail.com on 8 Aug 2009 at 1:49

[GoogleCodeExporter]

@ciawal: I assumed that this patch wouldn't apply easily on the trunk, but 
please
provide it anyway (especially the cleaning up) so I can get an idea of what 
you're
doing before I give you write access ...

@kevinhill: And with that measure you avoid a 17+ rating?

Original comment by din...@gmail.com on 8 Aug 2009 at 2:07

[GoogleCodeExporter]

Ok, I’ve rebased the appropriate commits against trunk into these four 
patches.

I’ll briefly explain the reasoning behind each:
The first patch removes the outlet to a TextDisplayViewController which is 
permanently in memory (along with its view!), and constructs the object only 
when 
necessary.
The second patch removes the xib for the text display view, and constructs the 
view 
programmatically when required.
This is mostly for the purposes of the third commit, which adds an isHTML 
property 
to TextDisplayViewController; when this is set the text provided will be 
displayed 
inside a webvie winstead.
The last patch just adds an HTML version of the credits and removes the old 
credits 
stuff.

Original comment by ciawal@gmail.com on 8 Aug 2009 at 2:55

Attachments:

• 0001-Cleaned-up-text-display-a-bit.patch
• 0002-Remove-the-xib-for-TextDisplayViewController-and-cre.patch
• 0003-Add-support-for-HTML-display-to-TextDisplayViewContr.patch
• 0004-Convert-credits-into-HTML-remove-credits-xib-and-vi.patch

[GoogleCodeExporter]

That's correct. Basically you can have internal anchor links to jump around the 
page. Anything else that would 
navigate to a page on the web is handled with that code I posted. Which of 
course means if parental controls are 
active on Safari it could fail... but that's what is desired. RT has a 9+ 
rating. And yes, I've actually had 9 and 10 
year olds playing it too ;)

Original comment by kevinh...@gmail.com on 8 Aug 2009 at 3:06

[GoogleCodeExporter]

You both should now have the right to commit. Have fun :)

@ciawal: I haven't committed your patches, feel free to do it.

Original comment by din...@gmail.com on 8 Aug 2009 at 3:38

[GoogleCodeExporter]

Ok, I’ve committed those to trunk (and marked this issue as fixed).

Do you want me to just go ahead and commit any other (non-gameplay-modifying) 
changes I have, or would you rather I put them on a branch or something so you 
can 
review them first?

Original comment by ciawal@gmail.com on 8 Aug 2009 at 3:55

• Changed state: Fixed

[GoogleCodeExporter]

To avoid clashes we all should try to own an issue before doing any work on it. 
If
that doesn't work please notify me.

Don't fix something that doesn't have an issue. Create one before and mention 
any
solved issue in the commit log.

Original comment by din...@gmail.com on 8 Aug 2009 at 4:01

[GoogleCodeExporter]

Just updated (with some local changes in winiphone.m that shouldn't have an 
effect):

- the credits show a white page
- the app hangs in several ways after credits

Original comment by din...@gmail.com on 8 Aug 2009 at 4:08

• Changed state: Accepted

[GoogleCodeExporter]

Found the cause of the crash, committed a fix.

Not sure about the empty credits though, could you check if credits.html is 
present 
in your working directory and in the project, and if it is being copied into 
the 
app? Maybe try a clean & build if it is not.

Original comment by ciawal@gmail.com on 8 Aug 2009 at 4:20

[GoogleCodeExporter]

oh and btw I have given up all issues I'm not currently working on, so anything
without me as owner is fair game :)

Original comment by din...@gmail.com on 8 Aug 2009 at 4:20

[GoogleCodeExporter]

Nice, I'll take a look at the issue list and see if I can lend a hand :)

Original comment by kevinh...@gmail.com on 8 Aug 2009 at 4:34

[GoogleCodeExporter]

Checked out fresh and now it works. Seems not to resize when you rotate while 
in the
credits.

Original comment by din...@gmail.com on 8 Aug 2009 at 6:22

[GoogleCodeExporter]

The resizing should have been fixed in r51.

Original comment by ciawal@gmail.com on 10 Aug 2009 at 11:50

• Changed state: Fixed