search

elimu-ai / ml-authentication

😶‍🌫️ Android application for authenticating the current student using face recognition
MIT License
16 stars 16 forks source link

Delete StudentImages if the featureExtraction can't be run #236 #254

Closed sladomic closed 7 years ago

sladomic commented 7 years ago

@jogrimst I just delete them if a file is missing anyway (so if the feature extraction would fail for a StudentImageCollectionEvent). The files, where the feature extraction was successful will stay on the device. But if you want we can also have an expired flag on the db which I set instead

sladomic commented 7 years ago

@jogrimst Now the StudentImageCollectionEvent and all connected StudentImages and StudentImageFeatures will be deleted if 1) a file is missing 2) feature extraction for a StudentImage fails

I just delete them in the db but not the files itself. Should I also delete the files or keep them for debugging?

jo-elimu commented 7 years ago

I just delete them in the db but not the files itself. Should I also delete the files or keep them for debugging?

@sladomic I suggest we keep them, just in case.