search

elimu-ai / webapp

🖥 Web application for hosting Android applications and educational content
https://hin.elimu.ai
MIT License
30 stars 54 forks source link

chore: #1677 Rename LetterSoundCorrespondence to LetterSound #1682

Closed SnehaHS65 closed 3 weeks ago

SnehaHS65 commented 1 month ago

This pull request addresses issue #1677 by renaming the class LetterSoundCorrespondence to LetterSound and updating all references throughout the codebase.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve renaming the LetterSoundCorrespondence entity to LetterSound across various files in the project. This includes updating method signatures, import statements, class properties, and database migration scripts. The purpose is to have a clearer and more concise naming structure within the data model and related functionalities, reflected consistently throughout the application.

Changes

Files/Modules Change Summary
.../LetterSoundContributionEventDao.java Updated method signatures and imports from LetterSoundCorrespondence to LetterSound.
.../LetterSoundContributionEventDaoJpa.java Altered parameter type in readAll method from LetterSoundCorrespondence to LetterSound.
.../LetterSoundDaoJpa.java Updated class and method signatures to work with LetterSound instead of LetterSoundCorrespondence.
.../LetterSoundPeerReviewEventDaoJpa.java Changed method signatures to use LetterSound instead of LetterSoundCorrespondence.
.../StringToLetterSoundCorrespondenceConverter.java Updated class to work with LetterSound instead of LetterSoundCorrespondence.
.../Word.java Changed class property and related methods to use LetterSound instead of LetterSoundCorrespondence.
.../LetterSoundCorrespondenceContributionEvent.java Modified import and property type from LetterSoundCorrespondence to LetterSound.
.../JpaToGsonConverter.java Renamed LetterSoundCorrespondence to LetterSound in imports and method signatures.
.../LetterSoundCorrespondenceUsageCountScheduler.java Replaced references to LetterSoundCorrespondence with LetterSound in method loops.
.../SoundUsageCountScheduler.java Updated import and loop iteration to use LetterSound instead of LetterSoundCorrespondence.
.../CsvContentExtractionHelper.java Modified returning types and method signatures from LetterSoundCorrespondence to LetterSound.
.../DbContentImportHelper.java Replaced LetterSoundCorrespondence with LetterSound in method signatures and imports.
.../LetterSoundCreateController.java, .../LetterSoundEditController.java, Updated import and parameter references from LetterSoundCorrespondence to LetterSound.
.../LetterSoundPeerReviewEventCreateController.java Changed import and variable types from LetterSoundCorrespondence to LetterSound.
.../WordCreateController.java, .../WordEditController.java Updated import statements and variable types to use LetterSound instead of LetterSoundCorrespondence.
.../WordCsvExportController.java Modified import and loop variable types from LetterSoundCorrespondence to LetterSound.
.../jpa-schema-export.sql Renamed tables related to LetterSoundCorrespondence to LetterSound, updated foreign key constraints.
.../2002133.sql Introduced a migration script to rename LetterSoundCorrespondence table to LetterSound.

Possibly related issues

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 35093efec841f6c7b2b8233c732bc090ce548afc and 6e9c8b434e533f6e86a842013ce15e873b08822b.
Files selected for processing (22) * src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java (2 hunks) * src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java (2 hunks) * src/main/java/ai/elimu/dao/jpa/LetterSoundContributionEventDaoJpa.java (2 hunks) * src/main/java/ai/elimu/dao/jpa/LetterSoundDaoJpa.java (2 hunks) * src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (2 hunks) * src/main/java/ai/elimu/logic/converters/StringToLetterSoundCorrespondenceConverter.java (1 hunks) * src/main/java/ai/elimu/model/content/Word.java (2 hunks) * src/main/java/ai/elimu/model/contributor/LetterSoundCorrespondenceContributionEvent.java (2 hunks) * src/main/java/ai/elimu/rest/v2/JpaToGsonConverter.java (3 hunks) * src/main/java/ai/elimu/tasks/LetterSoundCorrespondenceUsageCountScheduler.java (2 hunks) * src/main/java/ai/elimu/tasks/SoundUsageCountScheduler.java (2 hunks) * src/main/java/ai/elimu/util/csv/CsvContentExtractionHelper.java (5 hunks) * src/main/java/ai/elimu/util/db/DbContentImportHelper.java (2 hunks) * src/main/java/ai/elimu/web/content/letter_sound/LetterSoundCreateController.java (3 hunks) * src/main/java/ai/elimu/web/content/letter_sound/LetterSoundEditController.java (3 hunks) * src/main/java/ai/elimu/web/content/letter_sound/LetterSoundPeerReviewsController.java (1 hunks) * src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java (2 hunks) * src/main/java/ai/elimu/web/content/word/WordCreateController.java (3 hunks) * src/main/java/ai/elimu/web/content/word/WordCsvExportController.java (2 hunks) * src/main/java/ai/elimu/web/content/word/WordEditController.java (3 hunks) * src/main/resources/META-INF/jpa-schema-export.sql (9 hunks) * src/main/resources/db/migration/2002133.sql (1 hunks)
Files not summarized due to errors (1) * src/main/java/ai/elimu/web/content/letter_sound/LetterSoundPeerReviewsController.java: Error: Server error. Please try again later.
Files skipped from review due to trivial changes (2) * src/main/java/ai/elimu/util/db/DbContentImportHelper.java * src/main/resources/db/migration/2002133.sql
Additional context used
Learnings (17)
Common learnings
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/model/contributor/LetterSoundCorrespondenceContributionEvent.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/logic/converters/StringToLetterSoundCorrespondenceConverter.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/jpa/LetterSoundDaoJpa.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/model/content/Word.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/tasks/SoundUsageCountScheduler.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/jpa/LetterSoundContributionEventDaoJpa.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/tasks/LetterSoundCorrespondenceUsageCountScheduler.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/web/content/word/WordCsvExportController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/web/content/letter_sound/LetterSoundCreateController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/web/content/letter_sound/LetterSoundEditController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/web/content/word/WordEditController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/rest/v2/JpaToGsonConverter.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
Additional comments not posted (39)
src/main/java/ai/elimu/dao/jpa/LetterSoundDaoJpa.java (4)
`3-3`: **Import statement approved.** The import statement for `LetterSound` is correctly added. --- `12-12`: **Class declaration approved.** The class now correctly extends `GenericDaoJpa`. --- `32-37`: **Method `readAllOrderedByUsage` approved.** The method correctly uses `LetterSound` and the query is consistent with the new entity name. --- `41-46`: **Method `readAllOrderedByLettersLength` approved.** The method correctly uses `LetterSound` and the query is consistent with the new entity name.
src/main/java/ai/elimu/tasks/SoundUsageCountScheduler.java (1)
`9-9`: **Import statement approved.** The import statement for `LetterSound` is correctly added.
src/main/java/ai/elimu/dao/jpa/LetterSoundContributionEventDaoJpa.java (1)
`3-3`: **Import statement approved.** The import statement for `LetterSound` is correctly added.
src/main/java/ai/elimu/tasks/LetterSoundCorrespondenceUsageCountScheduler.java (1)
`6-7`: **LGTM! Import statement is correct.** The import statement for `LetterSound` is necessary and correctly added.
src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java (1)
`7-7`: **Import statement approved.** The import statement for `LetterSound` is correct.
src/main/java/ai/elimu/web/content/letter_sound/LetterSoundCreateController.java (3)
`11-11`: **Import statement approved.** The import statement for `LetterSound` is correct. --- `54-54`: **Variable declaration approved.** The variable `letterSound` has been correctly updated to reflect the new entity name. --- `72-72`: **Method parameter approved.** The method parameter `letterSound` has been correctly updated to reflect the new entity name.
src/main/java/ai/elimu/web/content/letter_sound/LetterSoundEditController.java (2)
`6-6`: **Import statement approved.** The import statement for `LetterSound` is correct. --- `88-88`: **Method parameter approved.** The method parameter `letterSound` has been correctly updated to reflect the new entity name.
src/main/java/ai/elimu/web/content/word/WordCreateController.java (3)
`17-17`: **Import statement approved.** The import statement for `LetterSound` is correct. --- `246-246`: **Variable declaration approved.** The variable `letterSoundCorrespondences` has been correctly updated to reflect the new entity name. --- `253-253`: **Loop variable approved.** The loop variable `letterSoundCorrespondence` has been correctly updated to reflect the new entity name.
src/main/java/ai/elimu/web/content/word/WordEditController.java (2)
`7-7`: **Import statement updated correctly.** The import statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`. --- `18-18`: **Import statement updated correctly.** The import statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`.
src/main/java/ai/elimu/rest/v2/JpaToGsonConverter.java (2)
`8-8`: **Import statement updated correctly.** The import statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`. --- `85-85`: **Method signature updated correctly.** The method signature has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`.
src/main/java/ai/elimu/util/csv/CsvContentExtractionHelper.java (2)
`7-7`: **Import statement updated correctly.** The import statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`. --- `8-8`: **Import statement updated correctly.** The import statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`.
src/main/resources/META-INF/jpa-schema-export.sql (17)
`58-58`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`. --- `60-60`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `LetterSoundCorrespondence_Letter` to `LetterSound_Letter`. --- `62-62`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `LetterSoundCorrespondence_Sound` to `LetterSound_Sound`. --- `64-64`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `LetterSoundCorrespondenceContributionEvent` to `LetterSoundContributionEvent`. --- `70-70`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `LetterSoundCorrespondencePeerReviewEvent` to `LetterSoundPeerReviewEvent`. --- `116-116`: **Table name updated correctly.** The table name has been updated to reflect the renaming of `Word_LetterSoundCorrespondence` to `Word_LetterSound`. --- `386-386`: **Table creation statement updated correctly.** The table creation statement has been updated to reflect the renaming of `LetterSoundCorrespondence` to `LetterSound`. --- `396-400`: **Table creation statement updated correctly.** The table creation statement has been updated to reflect the renaming of `LetterSoundCorrespondence_Letter` to `LetterSound_Letter`. --- `403-408`: **Table creation statement updated correctly.** The table creation statement has been updated to reflect the renaming of `LetterSoundCorrespondence_Sound` to `LetterSound_Sound`. --- `410-419`: **Table creation statement updated correctly.** The table creation statement has been updated to reflect the renaming of `LetterSoundCorrespondenceContributionEvent` to `LetterSoundContributionEvent`. --- `445-454`: **Table creation statement updated correctly.** The table creation statement has been updated to reflect the renaming of `LetterSoundCorrespondencePeerReviewEvent` to `LetterSoundPeerReviewEvent`. --- `920-928`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `LetterSoundCorrespondence_Letter` to `LetterSound_Letter`. --- `930-938`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `LetterSoundCorrespondence_Sound` to `LetterSound_Sound`. --- `940-948`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `LetterSoundCorrespondenceContributionEvent` to `LetterSoundContributionEvent`. --- `970-978`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `LetterSoundCorrespondencePeerReviewEvent` to `LetterSoundPeerReviewEvent`. --- `1140-1143`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `Word_LetterSoundCorrespondence` to `Word_LetterSound`. --- `1145-1146`: **Foreign key constraint updated correctly.** The foreign key constraint has been updated to reflect the renaming of `Word_LetterSoundCorrespondence` to `Word_LetterSound`.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.

Project coverage is 15.03%. Comparing base (b5eb83a) to head (6e9c8b4). Report is 8 commits behind head on main.

Files Patch % Lines
.../ai/elimu/util/csv/CsvContentExtractionHelper.java 0.00% 4 Missing :warning:
...i/elimu/web/content/word/WordCreateController.java 0.00% 3 Missing :warning:
.../ai/elimu/web/content/word/WordEditController.java 0.00% 3 Missing :warning:
.../LetterSoundCorrespondenceUsageCountScheduler.java 0.00% 2 Missing :warning:
...n/java/ai/elimu/util/db/DbContentImportHelper.java 0.00% 2 Missing :warning:
...tent/letter_sound/LetterSoundCreateController.java 0.00% 2 Missing :warning:
...t/letter_sound/LetterSoundCsvExportController.java 0.00% 2 Missing :warning:
...ontent/letter_sound/LetterSoundEditController.java 0.00% 2 Missing :warning:
...ontent/letter_sound/LetterSoundListController.java 0.00% 2 Missing :warning:
.../main/java/ai/elimu/dao/jpa/LetterSoundDaoJpa.java 50.00% 1 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1682 +/- ## ========================================= Coverage 15.03% 15.03% Complexity 452 452 ========================================= Files 249 249 Lines 7760 7760 Branches 812 812 ========================================= Hits 1167 1167 Misses 6541 6541 Partials 52 52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SnehaHS65 commented 4 weeks ago

@venkatesh2k3 , I have changed in all the java files as you mentioned, should I change in webapp folder(in jsp files) as well? Let me know and I can commit

SnehaHS65 commented 4 weeks ago

@jo-elimu , Can you review the latest commit now, I refactored LetterSoundCorrespondence.java to LetterSound.java, ran this command mvn jetty:run, included jpa-schema-export.sql in the PR and also added DB script for the same.

SnehaHS65 commented 3 weeks ago

Hi @jo-elimu , @nya-elimu , @venkatesh2k3 , can you please look at the latest changes that I did to rename LetterSoundCorrespondence to LetterSound. This is the first PR to just rename the LetterSoundCorrespondence database table as suggested by @jo-elimu. If you approve this, I can raise one more PR for renaming the LetterSoundCorrespondence_id references.

jo-elimu commented 3 weeks ago

Hi @jo-elimu , @nya-elimu , @venkatesh2k3 , can you please look at the latest changes that I did to rename LetterSoundCorrespondence to LetterSound. This is the first PR to just rename the LetterSoundCorrespondence database table as suggested by @jo-elimu. If you approve this, I can raise one more PR for renaming the LetterSoundCorrespondence_id references.

@SnehaHS65 If you look at your changes in jpa-schema-export.sql, you'll see that it contains around 16 changes, and these 16 changes would also have to be included in the DB migration script.

This is why I suggested above that we split #1677 into smaller pull requests to make each database migration less complicated.

I've created an example here: https://github.com/elimu-ai/webapp/pull/1713. This pull request only makes one small change (renaming from Word#letterSoundCorrespondences to Word#letterSounds). After merging that PR, we can perform a release and verify that the migration script runs without errors. If so, we can move on to another small part of the issue.

SnehaHS65 commented 3 weeks ago

Hi @jo-elimu , @nya-elimu , @venkatesh2k3 , can you please look at the latest changes that I did to rename LetterSoundCorrespondence to LetterSound. This is the first PR to just rename the LetterSoundCorrespondence database table as suggested by @jo-elimu. If you approve this, I can raise one more PR for renaming the LetterSoundCorrespondence_id references.

@SnehaHS65 If you look at your changes in jpa-schema-export.sql, you'll see that it contains around 16 changes, and these 16 changes would also have to be included in the DB migration script.

This is why I suggested above that we split #1677 into smaller pull requests to make each database migration less complicated.

I've created an example here: #1713. This pull request only makes one small change (renaming from Word#letterSoundCorrespondences to Word#letterSounds). After merging that PR, we can perform a release and verify that the migration script runs without errors. If so, we can move on to another small part of the issue.

@jo-elimu ,So there are ContributionEvent and PeerReviewEvent which uses this letterSoundCorrespondence, I will now only edit for ContributionEvent first and commit?

jo-elimu commented 3 weeks ago

@jo-elimu ,So there are ContributionEvent and PeerReviewEvent which uses this letterSoundCorrespondence, I will now only edit for ContributionEvent first and commit?

@SnehaHS65 Yes, that's right 🙂

I suggest you close this pull request, and open a new pull request only for renaming the LetterSoundCorrespondenceContributionEvent class. And remember to include the DB migration script as well (see similar example in 2004010.sql).

So in total we'll end up with 6 smaller PRs for closing #1677.