Closed jo-elimu closed 1 month ago
The changes involve renaming the parameter letterSoundCorrespondenceContributionEvent
to letterSoundContributionEvent
across multiple files and method declarations. This update affects method signatures, field declarations, query conditions, and related database schema updates. The overarching goal is to standardize the naming convention for consistency and clarity throughout the codebase.
File(s) | Change Summary |
---|---|
src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java |
Renamed parameter in method signatures. |
src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java |
Updated method queries to use the new parameter name. |
src/main/java/ai/elimu/model/contributor/LetterSoundCorrespondencePeerReviewEvent.java |
Renamed fields and corresponding getter/setter methods. |
src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java |
Updated method call to use the new setter method. |
src/main/resources/META-INF/jpa-schema-export.sql |
Renamed columns and updated foreign key constraints. |
src/main/resources/db/migration/2004009.sql |
Renamed a column in the LetterSoundCorrespondencePeerReviewEvent table. |
src/main/webapp/WEB-INF/jsp/content/letter-sound/edit.jsp |
Updated comparison condition within a <c:if> block to use the new parameter name. |
LetterSoundCorrespondence
to LetterSound
. This PR aligns with the object renaming requirements.Common learnings
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/webapp/WEB-INF/jsp/content/letter-sound/edit.jsp (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (3)
`18-21`: **LGTM!** The method signature and query condition have been correctly updated to use `LetterSoundContributionEvent`. --- `31-31`: **LGTM!** The query condition correctly references the renamed parameter `letterSoundContributionEvent.letterSound`. --- `53-55`: **LGTM!** The method signature and query condition have been correctly updated to use `LetterSoundContributionEvent`.src/main/webapp/WEB-INF/jsp/content/letter-sound/edit.jsp (1)
`244-244`: **LGTM!** The comparison condition has been correctly updated to use `letterSoundContributionEvent`.
Attention: Patch coverage is 0%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 15.26%. Comparing base (
28dac27
) to head (f47dcd2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
…ntributionEvent
refs #1677