Closed jo-elimu closed 1 month ago
The primary change involves renaming LetterSoundCorrespondencePeerReviewEvent
to LetterSoundPeerReviewEvent
throughout the codebase. This update affects class names, method names, database schema, and import statements. It standardizes references to the entity, improving clarity and consistency.
File(s) | Change Summary |
---|---|
src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java |
Updated method signatures to use LetterSoundPeerReviewEvent instead of LetterSoundCorrespondencePeerReviewEvent . |
src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java |
Replaced references to LetterSoundCorrespondencePeerReviewEvent with LetterSoundPeerReviewEvent . |
src/main/java/ai/elimu/model/contributor/LetterSoundPeerReviewEvent.java |
Renamed class from LetterSoundCorrespondencePeerReviewEvent to LetterSoundPeerReviewEvent . |
src/main/java/ai/elimu/web/content/letter_sound/LetterSoundPeerReviewsController.java |
Updated imports and variable types to reflect the change to LetterSoundPeerReviewEvent . |
src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java |
Changed import statements and variable declarations from LetterSoundCorrespondencePeerReviewEvent to LetterSoundPeerReviewEvent . |
src/main/resources/META-INF/jpa-schema-export.sql |
Renamed table LetterSoundCorrespondencePeerReviewEvent to LetterSoundPeerReviewEvent and updated the schema accordingly. |
src/main/resources/db/migration/2004010.sql |
Introduced SQL changes to drop LetterSoundPeerReviewEvent table and rename LetterSoundCorrespondencePeerReviewEvent table. |
LetterSoundCorrespondencePeerReviewEvent
to LetterSoundPeerReviewEvent
.Common learnings
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/model/contributor/LetterSoundPeerReviewEvent.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/web/content/letter_sound/LetterSoundPeerReviewsController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java (1)
``` Learnt from: venkatesh2k3 PR: elimu-ai/webapp#1682 File: src/main/java/ai/elimu/dao/LetterSoundContributionEventDao.java:13-13 Timestamp: 2024-07-06T17:37:44.413Z Learning: In the `LetterSoundContributionEventDao.java` file, the method signatures should use `LetterSoundContributionEvent` instead of `LetterSoundCorrespondenceContributionEvent` to maintain consistency with the renaming of entities. ```
src/main/resources/db/migration/2004010.sql (2)
`4-4`: **LGTM!** The `DROP TABLE` statement correctly drops the `LetterSoundPeerReviewEvent` table. --- `5-5`: **LGTM!** The `ALTER TABLE` statement correctly renames `LetterSoundCorrespondencePeerReviewEvent` to `LetterSoundPeerReviewEvent`.src/main/java/ai/elimu/model/contributor/LetterSoundPeerReviewEvent.java (1)
`11-11`: **LGTM!** The class `LetterSoundPeerReviewEvent` is correctly renamed and follows best practices.src/main/java/ai/elimu/dao/LetterSoundPeerReviewEventDao.java (1)
`10-18`: **LGTM!** The interface `LetterSoundPeerReviewEventDao` is correctly updated to use `LetterSoundPeerReviewEvent` and the method signatures follow best practices.src/main/java/ai/elimu/dao/jpa/LetterSoundPeerReviewEventDaoJpa.java (1)
Line range hint `11-62`: **LGTM!** The class `LetterSoundPeerReviewEventDaoJpa` is correctly updated to use `LetterSoundPeerReviewEvent` and the method implementations follow best practices.src/main/java/ai/elimu/web/content/letter_sound/LetterSoundPeerReviewsController.java (2)
`9-9`: **Import statement updated.** The import statement has been correctly updated to import `LetterSoundPeerReviewEvent`. --- `63-63`: **Variable type updated.** The variable type has been correctly updated to `List`. src/main/java/ai/elimu/web/content/peer_review/LetterSoundPeerReviewEventCreateController.java (2)
`11-11`: **Import statement updated.** The import statement has been correctly updated to import `LetterSoundPeerReviewEvent`. --- `57-57`: **Variable type updated.** The variable type has been correctly updated to `LetterSoundPeerReviewEvent`.src/main/resources/META-INF/jpa-schema-export.sql (2)
`413-413`: **Table creation statement updated.** The table creation statement has been correctly updated to create `LetterSoundPeerReviewEvent`. --- `910-916`: **Foreign key constraint updated.** The foreign key constraint has been correctly updated to reference `LetterSoundPeerReviewEvent`.
Attention: Patch coverage is 40.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 15.26%. Comparing base (
65755f1
) to head (4a0525f
).
Files | Patch % | Lines |
---|---|---|
...ew/LetterSoundPeerReviewEventCreateController.java | 0.00% | 2 Missing :warning: |
...letter_sound/LetterSoundPeerReviewsController.java | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
refs #1677