search

elimu-ai / webapp

🖥 Web application for hosting Android applications and educational content
https://hin.elimu.ai
MIT License
30 stars 57 forks source link

refactor(language): fil --> tgl #1731

Closed jo-elimu closed 3 months ago

jo-elimu commented 3 months ago

closes #1730

coderabbitai[bot] commented 3 months ago

Walkthrough

The update primarily focuses on changing the language configuration from "Filipino" (FIL) to "Tagalog" (TGL) throughout various components of the application. This includes modifications to property files, JSP files, CSS styling, and test cases to ensure consistency in language support and conditional logic.

Changes

File Path Change Summary
.../i18n/messages_en.properties Updated language keys and modified supported languages description.
.../jsp/content/word/create.jsp Changed conditional logic from 'FIL' to 'TGL'.
.../jsp/content/word/edit.jsp Updated language comparison from 'FIL' to 'TGL'.
.../jsp/contributions/publish.jsp Replaced "Filipino" with "Tagalog" in the supported languages list.
.../static/css/styles.css Changed background image for Tagalog based on content language.
.../EPubChapterExtractionHelperTest.java Updated test to load a different resource file for 'TGL'.
.../EPubImageExtractionHelperTest.java Renamed test methods and updated resource paths for 'TGL'.
.../EPubMetadataExtractionHelperTest.java Modified test method names and resource paths for 'TGL'.
.../EPubParagraphExtractionHelperTest.java Changed test method names and file paths for 'TGL'.

Sequence Diagram(s)

No sequence diagrams required due to the nature of the changes.

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 40717dee296a3b01895c2e676b4fc8b9970911f0 and bb377b28094dd78c8f3737739b32620ec82e6eea.
Files ignored due to path filters (24) * `pom.xml` is excluded by `!**/*.xml` * `src/main/resources/db/analytics_TEST/tgl/storybook-learning-events.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/audios.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/emojis.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/images.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/letter-sounds.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/letters.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/numbers.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/sounds.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/storybooks.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/syllables.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/videos.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_PROD/tgl/words.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/audios.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/emojis.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/images.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/letter-sounds.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/letters.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/numbers.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/sounds.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/storybooks.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/syllables.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/videos.csv` is excluded by `!**/*.csv`, `!**/*.csv` * `src/main/resources/db/content_TEST/tgl/words.csv` is excluded by `!**/*.csv`, `!**/*.csv`
Files selected for processing (9) * src/main/webapp/WEB-INF/i18n/messages_en.properties (1 hunks) * src/main/webapp/WEB-INF/jsp/content/word/create.jsp (1 hunks) * src/main/webapp/WEB-INF/jsp/content/word/edit.jsp (1 hunks) * src/main/webapp/WEB-INF/jsp/contributions/publish.jsp (1 hunks) * src/main/webapp/static/css/styles.css (1 hunks) * src/test/java/ai/elimu/util/epub/EPubChapterExtractionHelperTest.java (1 hunks) * src/test/java/ai/elimu/util/epub/EPubImageExtractionHelperTest.java (1 hunks) * src/test/java/ai/elimu/util/epub/EPubMetadataExtractionHelperTest.java (5 hunks) * src/test/java/ai/elimu/util/epub/EPubParagraphExtractionHelperTest.java (3 hunks)
Files skipped from review due to trivial changes (3) * src/main/webapp/WEB-INF/i18n/messages_en.properties * src/main/webapp/WEB-INF/jsp/contributions/publish.jsp * src/main/webapp/static/css/styles.css
Additional comments not posted (12)
src/test/java/ai/elimu/util/epub/EPubImageExtractionHelperTest.java (1)
`53-55`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL".
src/test/java/ai/elimu/util/epub/EPubChapterExtractionHelperTest.java (1)
`45-45`: **LGTM!** The resource path has been correctly updated to use the new language code "TGL".
src/test/java/ai/elimu/util/epub/EPubMetadataExtractionHelperTest.java (5)
`34-36`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `48-50`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `62-64`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `102-104`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `91-91`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "BEN".
src/test/java/ai/elimu/util/epub/EPubParagraphExtractionHelperTest.java (3)
`130-132`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `145-147`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL". --- `159-161`: **LGTM!** The method name and resource path have been correctly updated to use the new language code "TGL".
src/main/webapp/WEB-INF/jsp/content/word/create.jsp (1)
Line range hint `175-189`: **LGTM!** The change correctly updates the language configuration from "Filipino" (FIL) to "Tagalog" (TGL).
src/main/webapp/WEB-INF/jsp/content/word/edit.jsp (1)
Line range hint `366-380`: **LGTM!** The change correctly updates the language configuration from "Filipino" (FIL) to "Tagalog" (TGL).
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.26%. Comparing base (40717de) to head (bb377b2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1731 +/- ## ========================================= Coverage 15.26% 15.26% Complexity 450 450 ========================================= Files 248 248 Lines 7584 7584 Branches 799 799 ========================================= Hits 1158 1158 Misses 6376 6376 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.