search

elimu-ai / webapp

🖥 Web application for hosting Android applications and educational content
https://hin.elimu.ai
MIT License
30 stars 55 forks source link

refactor(languages): reduce number of supported languages #1744

Closed jo-elimu closed 1 month ago

jo-elimu commented 1 month ago

To ease cost of maintenance, remove Bengali, Swahili, Urdu, Xhosa. And keep only English, Hindi, Tagalog.

closes #1733

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes primarily involve renaming and updating test methods to reflect new resource names and languages in EPubChapterExtractionHelperTest, EPubImageExtractionHelperTest, and EPubMetadataExtractionHelperTest. Additionally, there are modifications in EPUB resource files to update metadata, chapter references, and image links. Some test methods have been removed to align with reduced language support.

Changes

Files/Groups Change Summary
src/test/.../EPubChapterExtractionHelperTest.java Renamed test methods to reflect specific languages and sources. Removed the method for STORYWEAVER.
src/test/.../EPubImageExtractionHelperTest.java Removed two test methods and added a new one for GLOBAL_DIGITAL_LIBRARY_eng.
src/test/.../EPubMetadataExtractionHelperTest.java Renamed and updated test methods to align with new book resource names and expected values.
src/test/resources/... Updated metadata, chapter references, and image links in various EPUB resource files, including eng-gdl-1349.epub_toc.xhtml, hin-sw-99651-hamare-mitra-kon-hai.epub_toc.ncx, eng-gdl-1349.epub_book.opf, and hin-sw-10145-ek-sau-saintisvan-paer.epub_package.opf.

Assessment against linked issues

Objective Addressed Explanation
Reduce number of supported languages (#1733) ✅
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between b9addb6f30d60759f96a5962357d2a361ec0a1f5 and 442163958cb8d84ca166adc8df04abda40cb3e0a.
Files ignored due to path filters (1) * `pom.xml` is excluded by `!**/*.xml`
Files selected for processing (1) * src/test/java/ai/elimu/util/epub/EPubMetadataExtractionHelperTest.java (5 hunks)
Files skipped from review as they are similar to previous changes (1) * src/test/java/ai/elimu/util/epub/EPubMetadataExtractionHelperTest.java
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.25%. Comparing base (305c9cf) to head (4421639).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1744 +/- ## ============================================ - Coverage 15.26% 15.25% -0.02% + Complexity 450 449 -1 ============================================ Files 248 248 Lines 7584 7584 Branches 799 799 ============================================ - Hits 1158 1157 -1 - Misses 6376 6377 +1 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.