search

elinw / AssetFix

Application for fixing assets
16 stars 17 forks source link

not working with Joomla 3.4 #8

Open bobgal opened 8 years ago

bobgal commented 8 years ago

hi elinw

will produce the following error message

Notice: Undefined index: HTTP_HOST in D:\website\kaj3\libraries\joomla\application\web.php on line 869 Error displaying the error page: Application Instantiation Error: Application Instantiation Error

I hope you can help

thanks bob

profesorproton commented 8 years ago

Same on 3.51 :(

photodude commented 7 years ago

This package is very outdated and uses features not available in J3.4+.

I just closed a PR I had opened against this to solve some of the issues as @elinw had not responded in 2 years. I assume this is an abandoned project.

elinw commented 7 years ago

If you have the asset problems that this is designed to fix (which resulted from failed migration management from 1.5 to 1.6) that are still in place at this point you need to re-evaluate. This code was specifically designed to address issues due to failed migrations from that initial time. I'd always suggest starting to rebuild from scratch at this point in history ... delete all but the root and rebuild your category structure and then your other items. Assets now are even more complex.

Also please be aware that this is github, you should just fork the code if you think you can fix it and make it useful. I am not hurt by this! I think it is great if someone forks and updates.

photodude commented 7 years ago

@elinw I've seen Asset problems from 1.7 and 2.5 migration/updates as well. Unfortunately, there are still sites migrating to things like J3.6 from those old versions and ending up with asset issues.

I agree clean rebuilds are usually best, but it's hard to convince some Small Business Owners to invest in that route.

elinw commented 7 years ago

I can imagine, I still come across Joomla 1.0 sites.
So what I’d suggest is that you fork the script and try to fix it up so it works. I think the logic is basically correct, it probably just needs modernizing. I am not currently doing Joomla code so I have not kept up with any of that and wouldn’t be the person to do it. But I feel it’s a relatively clean script that someone could update.

Elin

On Apr 1, 2017, at 9:57 PM, Walt Sorensen notifications@github.com wrote:

@elinw https://github.com/elinw I've seen Asset problems from 1.7 and 2.5 migration/updates as well. Unfortunately, there are still sites migrating to things like J3.6 from those old versions and ending up with asset issues.

I agree clean rebuilds are usually best, but it's hard to convince some Small Business Owners to invest in that route.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elinw/AssetFix/issues/8#issuecomment-290959329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuEfTbPQ7LTKpJJbpdcyizFpg7eq-ySks5rrwCUgaJpZM4GnOQt.

photodude commented 7 years ago

Will do, Thank you. I'll look at making a new official fork of this updated for J3.x.

ghost commented 7 years ago

were you able to do this photodude? i have a working joomla site, but i noticed alot of negative values for lft and right and many instances (including my root) where lft is much greater than rgt which i don't think should ever happen... so something is hosed...

i havevn't migrated this site, it was built on j3, but the asset table seems corrupt.

ghost commented 7 years ago

fyi... followed photodude and the code here does execute. didn't swap my lft and rgt's so that rgt>lft, but it did execute on a J!3.7.4 site using php 7 and didn't break anything so that's a great start!

https://github.com/photodude/AssetFix

photodude commented 7 years ago

@barrycox I've started the work on it but there was a problem with this kind of CLI in certain Joomla versions, I think anything from J3.0-3.6 has the problem. I have not had time to test and address the issues further. You can see the current development version at https://github.com/photodude/AssetFix all issues and work should be directed there now.

ghost commented 7 years ago

thanks so much for your work! many of my issues seem to be with an asset named #__ucm_content.442 (where 442 is many numbers... 1000s of them). i think it's to do with the new versioning perhaps. so i'll see if that can be added fo assetfix perhaps.