eliocamp / ggnewscale

Multiple Fill, Color and Other Scales in `ggplot2`
https://eliocamp.github.io/ggnewscale/
GNU General Public License v3.0
398 stars 18 forks source link

Issues with next version of ggplot2 #53

Closed thomasp85 closed 1 year ago

thomasp85 commented 1 year ago

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that this is due to changes in the warnings and errors thrown by ggplot2 that you test for in your package

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards Thomas

eliocamp commented 1 year ago

The problem is that I'm testing for partial matching and is seems that this version of ggplot2 does partial matching somewhere in the code:

library(ggplot2)

options(warnPartialMatchDollar = TRUE)
ggplot(mpg, aes(displ, hwy)) +
  geom_point(aes(colour = factor(year)), size = 5)
#> Warning in panel_params$guide: partial match of 'guide' to 'guides'

Created on 2022-10-07 by the reprex package (v2.0.1)

Is that something that needs to change in ggplot2 or should I change my tests in some way?

thomasp85 commented 1 year ago

Let me get back to you on this - it could look like an issue in ggplot2

eliocamp commented 1 year ago

I think this is the offending line:

https://github.com/tidyverse/ggplot2/blob/075170c04ad30b5695e890e771c2f04365273867/R/coord-.r#L65

thomasp85 commented 1 year ago

You are right, this is the issue - sorry for the noise and thanks for the debug 🙂