search

eliocamp / metR

Tools for Easier Analysis of Meteorological Fields
https://eliocamp.github.io/metR/
139 stars 22 forks source link

Guide methods #177

Closed teunbrand closed 9 months ago

teunbrand commented 1 year ago

Hi Elio,

Apologies for putting in multiple PRs to your packages! This is again a PR to keep guides compatible with the development version of ggplot2. In this case, there were just some missing methods that have been removed from ggplot2. It's a work in progress (WIP) as I'm still figuring out what changes would be needed upstream in ggplot2 to make as many S3 guides compatible as I reasonably can.

Best, Teun

eliocamp commented 1 year ago

No need to apologise! Thank you for the work!

teunbrand commented 1 year ago

This PR is ready for review, but I saw a few failures that appeared unrelated to this PR.

eliocamp commented 1 year ago

Great. Very appreciated. I'll check it out in a few weeks.