search

eliotlee68 / pe

0 stars 0 forks source link

Name does not accept non-alphanumeric characters despite s/o being a common occurrence in legal names #7

Open eliotlee68 opened 7 months ago

eliotlee68 commented 7 months ago

image.png

s/o is a common occurrence in legal names in Singapore, and it is not accepted in the name field as only alphanumeric characters are accepted

medium as it impacts the user experience quite significantly when the error is run into (the client's name cannot be added)

nus-se-script commented 7 months ago

Team's Response

The error message is correct, and our decision to accept only alphanumeric characters is because / is used in the command format. This is also a problem that does not cause major inconvenience to the user, and can easily be avoided by using "son of" or "daughter of" instead of the abbreviated form, although it is a good suggestion which can be implemented, so it should have a low severity.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

App does not support adding of name with s/o (denoting son of)

The app should support adding of name with s/o as it is a valid name.

image.png

[original: nus-cs2103-AY2324S2/pe-interim#4180] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The error message is correct, and our decision to accept only alphanumeric characters is because / is used in the command format. This is also a problem that does not cause major inconvenience to the user, and can easily be avoided by using "son of" or "daughter of" instead of the abbreviated form, although it is a good suggestion which can be implemented.

It has been specified that the character / cannot be part of the parameters. From the UG: Screenshot 2024-04-20 at 11.56.42 PM.png

While this may be a good feature to have, changing the command format to accommodate the character is out of the scope of v1.4. and it fulfils the second point here from the textbook. Screenshot 2024-04-20 at 11.58.57 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]